Make margins on home screen consistent

Western-Health-Covid19-Collaboration / wh_covid19_app

Volunteer developed app containing information for frontline medical staff around COVID-19

29 stars 8 forks source link

Make margins on home screen consistent #316

Closed yimingc2 closed 4 years ago

yimingc2 commented 4 years ago

Resolved #314

Abstract

This PR will fix the inconsistent gaps on home screen. This issue is because the incorrect way of setting the default value in ReusableCard.fromData. If you don't specify the margin in its constructor, it will pass null to the card.

Changes

Add default values for height and margin in the constructor of ReusableCard.fromData

Screenshots

Simulator Screen Shot - iPhone 11 Pro - 2020-05-02 at 23 01 51

workerbee22 commented 4 years ago

@yimingc2 As per last night meeting, I assume this is still a WIP (Work In Progress) as you are looking at why the green cards are not as tall as the blue or white cards? So I'll rename to add [WIP] to the name.

yimingc2 commented 4 years ago

Hey guys, I change the height of all cards in home screen to be consistent as 108dp.

sallychung commented 4 years ago

✅ 1.0.173