search

Western-Health-Covid19-Collaboration / wh_covid19_app

Volunteer developed app containing information for frontline medical staff around COVID-19
29 stars 8 forks source link

Add place holder for last updated time #333

Closed yimingc2 closed 4 years ago

yimingc2 commented 4 years ago

Resolved #288

Abstract

This PR will add a placeholder for the last updated time in env.dart. Then CI should update this variable in a format of 10:17pm 07 May 2020

Changes

Screenshots

Screenshot_1588854003

Things to note

If CI has not added the last updated time, then CI might overwrite env.dart and variable lastUpdatedTime will disappear. And it could result in build failure. @maks

lukesleeman commented 4 years ago

So, I pulled down the last build from the #covid-19-app-builds channel, but unfortunately I can't see any last update date in it. Not sure if its supposed to be showing up yet?

yimingc2 commented 4 years ago

So, I pulled down the last build from the #covid-19-app-builds channel, but unfortunately I can't see any last update date in it. Not sure if its supposed to be showing up yet?

Yeah, that's okay. I just add a placeholder for the last updated time. CI will assign a value(the updated time) for this placeholder when Codemagci is running and after CI build successfully, we will be able to see the last updated date.

Maks is working on the CI part atm.

workerbee22 commented 4 years ago

its a one liner in the pre script in codemagic. After thats in it should work fine.

On Fri, 8 May 2020, 7:22 pm June Chen, notifications@github.com wrote:

So, I pulled down the last build from the #covid-19-app-builds channel, but unfortunately I can't see any last update date in it. Not sure if its supposed to be showing up yet?

Yeah, that's okay. I just add a placeholder for the last updated time. CI will assign a value for this placeholder when Codemagci is running and after CI build successfully, we will be able to see the last updated date.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Western-Health-Covid19-Collaboration/wh_covid19_app/pull/333#issuecomment-625726046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKO2DG3ZLDJBUXQH7ARS3RQPFLVANCNFSM4M3JDBIA .

maks commented 4 years ago

Ok I've added to CI the timestamp as seconds after epoch, @yimingc2 you can then just easily format it as needed on Dart side. I've also added this to PR build workflow and kicked off a new PR build with this PR branch to test it out.

yimingc2 commented 4 years ago

Hi @maks @lukesleeman , I've tested out on Android side with the CI build. It works well. Thanks for @workerbee22 advice on timestamp. Screenshot_1588992441

yimingc2 commented 4 years ago

Nice. Thanks Luke. I’ll test it out again after this version is uploaded to TestFlight. Just in case.

On Sat, 9 May 2020 at 3:32 pm, Luke Sleeman notifications@github.com wrote:

@lukesleeman approved this pull request.

I've downloaded the CI build and confirmed that it contains the build date! I've also run this locally based off source and can confirm that everything is fine in a dev enviorment when the value isn't set.

Can't speak to the flutter side of things, but based on my testing this PR gets the ✅

Good job @yimingc2 https://github.com/yimingc2 and @maks https://github.com/maks 🙌

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Western-Health-Covid19-Collaboration/wh_covid19_app/pull/333#pullrequestreview-408614501, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADK4WO37JZGZ5T3GLV4FMZ3RQTTIDANCNFSM4M3JDBIA .