search

Western-Health-Covid19-Collaboration / wh_covid19_app

Volunteer developed app containing information for frontline medical staff around COVID-19
29 stars 8 forks source link

Display failed codemagic builds in PRs #98

Closed lukesleeman closed 4 years ago

lukesleeman commented 4 years ago

I investigated some PRs that got stuck last night:

https://github.com/Western-Health-Covid19-Collaboration/wh_covid19_app/pull/89 https://github.com/Western-Health-Covid19-Collaboration/wh_covid19_app/pull/82

And it seems the build is actually failing due to code style errors. However if you look at the PR it looks like we are just waiting on the build to complete:?

image

Yet if you go into codemagic, its failed: https://codemagic.io/app/5e75f4bfdd1d6d000a198e90/build/5e7c92e629657a000e2e3ebc

It would be good to show the failed build status in the PR

lukesleeman commented 4 years ago

Just checking in with @maks and @workerbee22 on this one - is it something simple we can easily fix up, a bug with codemagic, or some huge bit of work?

workerbee22 commented 4 years ago

@maks is looking at it

maks commented 4 years ago

@lukesleeman yes, I fixed it a few days ago, I think the overnight missing statuses is because Codemagic support has reported they had some issues with recent maintenance and had to do a DB rollback.

lukesleeman commented 4 years ago

Cool. You happy for me to close this issue then?

lukesleeman commented 4 years ago

Just an update, I saw this happening again last night, so it seems whatever is happening at the CM end with their DB's hasn't been fixed yet

lukesleeman commented 4 years ago

It's still occurring on and off, but I don't think there is much we can actually do about it. We have a reasonable work around which is to just push through a small commit to kick off the build again.

Perhaps I could update the Readme.md with the work around and then we can close this issue. What do you think @maks ?

maks commented 4 years ago

@lukesleeman :+1: This seems to actually be mostly a Github issue. Looking on CI, they complete successfully and since i wrote the work-around script that notifies Github I think its actually error on their end but with GH so swamped and unresponsive at the moment not much more we can do. I'll add a note to the Readme for this.

lukesleeman commented 4 years ago

@lukesleeman 👍 This seems to actually be mostly a Github issue. Looking on CI, they complete successfully and since i wrote the work-around script that notifies Github I think its actually error on their end but with GH so swamped and unresponsive at the moment not much more we can do. I'll add a note to the Readme for this.

No worries, close this issue once we have the note in the readme. Might also be good to add something to the FAQ section of the github101.md as well 🙂

lukesleeman commented 4 years ago

Assigning to me to update the readme.