Fix Contact slug generator script or find a better solution

WesternFriend / westernfriend.org

A website for Western Friend (westernfriend.org), a Quaker publication that provides resources and support for Quaker communities and individuals seeking to live out their faith in the world. Western Friend is part of the Religious Society of Friends.

https://westernfriend.org

GNU Affero General Public License v3.0

57 stars 39 forks source link

Fix Contact slug generator script or find a better solution #773

Open brylie opened 1 year ago

brylie commented 1 year ago

We generate a slug for Contacts in the Wagtail Admin UI by using a custom script. However, the script is currently broken and is somewhat brittle. Fix the script and/or find a more resilient solution.

brylie commented 1 year ago

The code seems to be working today, perhaps it was a transient bug. However, here are some ideas for improvement:

only run the code when editing a person, not on other Wagtail edit forms
add error handling
consider removing unicode characters by default (research whether to allow unicode in URL slugs as a best practice)
consider using const for slug_text in the generateAutoslug function
unit test the code (both via the Wagtail Admin UI and as generic tests)

brylie commented 1 year ago

I tried again to set the PersonModelAdmin.form_view_extra_js bug got no JS response from Wagtail Admin. I'm not sure what might be the cause, and got no response on StackOverflow:

https://stackoverflow.com/questions/76687506/unable-to-load-custom-js-via-wagtail-modeladmin-form-view-extra-js

brylie commented 1 year ago

Moving this to post-launch since I've repeatedly tried to get it to load only on the Person form page.