search

WestpacCXTeam / GUI-source

Westpac GUI source code
http://WestpacCXTeam.github.io/GUI-source
GNU General Public License v2.0
37 stars 19 forks source link

Body background colour setting #376

Closed jonnystening closed 7 years ago

jonnystening commented 7 years ago

The _text-styling module sets a body background colour mapped to @color-Background as part of its text styling setup.

It was never our intention for GUI to enforce a website background colour. The @color-Background variable naming is a little confusing; intended to be used for subtle background shade fills for a number of modules including Panels (header), Modals (footer), Button dropdown (headline) and :hover styling for Pagination, Tables and Tabcordion.

GUI framework manages the atomic modules, it does not manage or mandate the page wrapping document styling. We do include the common 'Normalize' normalisation library in the _text-styling module, but really each web UI implementation should include a background colour setting on a implementation-by-implementation basis, as per best practice (which states "you should always set a default document background-color").

I would like to propose an approach similar to Bootstrap v4's, where the design system has its own unique 'Reboot' module (https://getbootstrap.com/docs/4.0/content/reboot/), based on 'Normalize' but uniquely optimised to reset the base elements as required by the system's modules.

jonnystening commented 7 years ago

We're going to remove this background colour setting to make things clearer