search

WestpacCXTeam / GUI-source

Westpac GUI source code
http://WestpacCXTeam.github.io/GUI-source
GNU General Public License v2.0
37 stars 19 forks source link

Ensure we use consistent npm packages #417

Closed jonnystening closed 6 years ago

jonnystening commented 6 years ago

With additional developers joining the team it's important we ensure we're all using the same npm packages for build. Especially with packages that generate code output such as grunticon, uglify etc. These two in particular may cause inconsistent output between devs if we're not careful, which will be a Git nightmare.

grunt-contrib-uglify's recent 'minor' bump from v3.2.0 to v3.3.0 has proved this, as the uglify-js dependency bump brings about slightly different min'd JS output.

Lock file time?

jonnystening commented 6 years ago

All submodule package.json files have been updated with consistent package versions and package-lock.json added.

🤞