Wet-Boys / LethalEmotesAPI

Great repository names are short and memorable. Need inspiration? How about scaling-octo-happiness ?
GNU Lesser General Public License v3.0
3 stars 2 forks source link

LethalEmotesAPI causing errors after second opening of a world. #77

Closed Vexxingfr closed 8 months ago

Vexxingfr commented 8 months ago

I'm not sure this has been documented yet, but I couldn't find a single hint of it through looking through this github and searches online. There seems to be an error with the LethalEmotesAPI v1.1.11 where if you are to exit to menu and reopen a run or a session, the entire session breaks making it so that items don't appear and hand and disappear into the void after being dropped as well as not allowing the use of the terminal and its function. The first time opening a lobby seems to work fine so I am not sure how much of a problem it is for the developer at this current moment but it causes for some really bad hiccups with people on unstable connections. This was tested using only the mod and its necessities downloaded so it is not of an problems with mod interference. If this issue is solvable thank you for taking the time of your day to fix this error!

image_2024-01-11_002701883 This is the list tested and I am uploading a video in order to show the issue at hand.

Vexxingfr commented 8 months ago

https://youtu.be/yrSjp86JPYM Heres a follow up video on the issue using those same few mods with no other interference. I have tested base game and my modpack without the LethalEmotesAPI and it worked perfectly fine so its the only conclusion that I could come up with my hour to two hours of testing mods one by one.

Rune580 commented 8 months ago

interesting, do you also happen to have the logs?

HamedAlmanthari commented 8 months ago

omg i was trying to find out which mod was causing this from over 100 mods that i have lmao. i just found out and was going to open an issue. this mod also happens to cause alot of performance loss, i'm not sure why.

HamedAlmanthari commented 8 months ago

also, after rehosting, when you pick up stuff and throw them, they disappear or get thrown outside of the ship. and also, it glitches when you interact with the terminal after rehosting.

Rune580 commented 8 months ago

omg i was trying to find out which mod was causing this from over 100 mods that i have lmao. i just found out and was going to open an issue. this mod also happens to cause alot of performance loss, i'm not sure why.

Could you provide a modpack code, so that we can do some performance profiling

HamedAlmanthari commented 8 months ago

nevermind about the performance loss 💀 i thought because i disabled this mod i got more fps but that was not the case. sorry for the misinformation.

HamedAlmanthari commented 8 months ago

the rest still happens tho.

HamedAlmanthari commented 8 months ago

profile code: 018cf990-fb41-147f-ab6d-eb644b7e2564

Dependency string list

BepInEx-BepInExPack-5.4.2100 AinaVT-LethalConfig-1.3.4 Rune580-LethalCompany_InputUtils-0.4.4 Gemumoddo-LethalEmotesAPI-1.1.11

after rehosting: image image more issues with grabbing items and dropping items

LogOutput.log

this is my modpack: 018cf995-01e7-0f52-5154-739f60b15fb7 more things break after rehosting with other mods like toomanyemotes.

Rune580 commented 8 months ago

See where the issue is, marking this as a confirmed bug. We'll look into it as soon as we can

Vexxingfr commented 8 months ago

Thank you for providing the information for me, I was asleep and the issue is getting looked into faster because of you @HamedAlmanthari :3

Rune580 commented 8 months ago

Comparing this to an older issue we had, this seems to be a regression of #44

Vexxingfr commented 8 months ago

yeah seems to be the sameish issue, thank you for putting the time and effort to fix the issue! Was very sad to not be able to use this mod for a bit but hopefully it gets resolved soon. ty i love you :3333

HamedAlmanthari commented 8 months ago

i'm still using this mod i don't care because it's so good 💀

ToastedOven commented 8 months ago

Yeah this was a very shortsighted mistake I made, was trying to clean up objects we spawned but I didn't do it properly. It's working on my branch, once I get through a few more bug reports it should get pushed out (aka sometime tonight)

Vexxingfr commented 8 months ago

nice thank you for everything, we host sessions friday so having this fixed is really cool thank you!

HamedAlmanthari commented 8 months ago

i guess this is what actually happens after rehosting (that is me and the flashlight i'm holding) 💀 image

hoffor commented 4 months ago

it appears that this is still a bug. sorry this profile is absolutely massive (and unfinished, still narrowing down bugs with other mods): 018fb5de-4c62-5f88-8357-cd07b854b110