Critwithluck calculations still seem broken with Purity.

Wet-Boys / LookingGlass

A QoL UI mod that exposes statistics for items and the player, adjusts the size and features of command and scrapper menus, and much more. Fully open source and compatible with RiskUI!

https://thunderstore.io

GNU Lesser General Public License v3.0

9 stars 5 forks source link

Critwithluck calculations still seem broken with Purity. #14

Closed Shiranui-Izayoi closed 1 month ago

Shiranui-Izayoi commented 1 month ago

While it no longer shows 1% when having purity they still seem broken as when I picked one up my displayed crit chance increased to 121% despite having only 11% crit at the time. Thanks to having 1 irradiant pearl see image below.

Shiranui-Izayoi commented 1 month ago

Judging by the number the value is accidentally being multiplied by 100. Since the correct value is 1.21

ToastedOven commented 1 month ago

You are right, I wasn't reducing the input value (ror2 stores it as a literal value, so 100% == 100, whereas I need it as a number between 0-1 so 50% == .5)

This has been fixed in 1.2.6