Add two new settings: Full Item Description On Pickup and StatsDisplay Update Interval

SSM240 commented 1 month ago

This adds two new settings to the mod:

Full Item Description On Pickup: This is really a separation of one setting into two separate ones. Now you can separately toggle whether you want the short or full descriptions on the item pickup notification, without losing out on the more detailed stats on the Tab screen.
StatsDisplay update interval: Lets the stats update more than once every 1/3rd second. I'm guessing the low update rate was done out of an abundance of caution for performance, but having the option to make it more responsive (with a note that it may affect performance) seems like a good idea to me.

If you'd prefer me to separate these into individual PRs, I can do that, but I figured it's simplest for now to combine them.

also bonus fun fact: this was initially going to have four settings, but you literally added two of them (stats display font size + disabling colors) to main while i was working on this so that's kinda funny (and also made my first fork branch kind of a mess which was made even more confusing when I attempted to rebase so I just abandoned that and manually transferred my changes to a new branch xd)

ToastedOven commented 1 month ago

oh, yeah sorry about that, I've just been kinda pushing stuff directly since it's just been me working on stuff until now

ToastedOven commented 1 month ago

yeah looks good to me chief. Gonna merge this for the next update. Btw, do you wanna be in the credits on the readme? Full disclaimer I got this little nugget earlier today, probably just some troll but letting you know before I toss you in the credits. Discord_RtTB3kDnUc

SSM240 commented 1 month ago

oh, yeah sorry about that, I've just been kinda pushing stuff directly since it's just been me working on stuff until now

No worries lol, I just find it funny how you added the exact features I was actively in the process of making a PR for while I was doing it. Great minds think alike I guess :p

Btw, do you wanna be in the credits on the readme? Full disclaimer I got this little nugget earlier today, probably just some troll but letting you know before I toss you in the credits.

Yeah I'm not too worried about it. I feel like worst case scenario I get a good laugh and then hit the block button.

Wet-Boys / LookingGlass

Add two new settings: Full Item Description On Pickup and StatsDisplay Update Interval #19