WgtTelia / Telia-e-shop-front-end

Storefront UI for Women Go Tech project by Telia
https://telia-web-shop.netlify.app/
1 stars 0 forks source link

TES-80 fix: API response data structure #30

Closed WitchDevelops closed 2 months ago

WitchDevelops commented 2 months ago
netlify[bot] commented 2 months ago

Deploy Preview for telia-web-shop ready!

Name Link
Latest commit b5823e1504dbd8df8fcd230b3c35120f929822d2
Latest deploy log https://app.netlify.com/sites/telia-web-shop/deploys/66fc55e7cd5fe8000861a3ed
Deploy Preview https://deploy-preview-30--telia-web-shop.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 70
Accessibility: 100
Best Practices: 83
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

KozerT commented 2 months ago

🟢 This code is looking really good! 👍 I especially like how you've utilized types effectively . The enhancements to the test cases are also a big plus. 🟥 Prettier checks are failing. We need to reformat " npm run format " before pushing To make this code even more solid, we can:

Reduce redundancy: The getObject and getAll functions are quite similar. Error handling: Adding a catch block to the API calls (getObject) would provide a safety net for any future error handling needs.