search

WhatSock / apex

Apex 4X: The Comprehensive ARIA Development Suite
MIT License
29 stars 9 forks source link

General improvements #25

Closed LaurenceRLewis closed 1 year ago

LaurenceRLewis commented 3 years ago

Fix styles for:

Improving visually styles for:

Review use of Test pages heading for the components Parent page. It does not really work.

accdc commented 3 years ago

"Review use of Test pages heading for the components Parent page. It does not really work."

I appreciate the enhancements as always, but I'm not sure about this one. How does the heading not work?

Thanks, Bryan

LaurenceRLewis commented 3 years ago

Hi @accdc

In my opinion this set of pages needs a heading above the instructional content, and below the navigation, that describes the purpose. Having the main page heading that people encounter as Test pages is potentially confusing. Test pages is a heading for the navigation only. Personally I really don't see a need for this as the navigation is self explanatory due to styling and position. On the Component pages the Test pages heading is associated with the menu due to its vertical alignment.

On these parent pages my suggestion is to remove the Test pages heading and incorporate a descriptive main page heading that describes the page content.

Noting this is a personal observation and happy to get others feedback :-)

Example page ARIA Comboboxes

accdc commented 3 years ago

That sounds good to me, though Test Pages will still need to be a heading, even if it is a fake one using role="heading" plus aria-level, because it helps a lot for blind folks like me to quickly locate that particular section. :)

accdc commented 1 year ago

I'm going to close this as an issue for now. Please open again if it is still relevant.