Whatang / DrumBurp

A simple drum tab editor, designed to make it quick and easy to enter drum tabs.
http://whatang.org/
GNU General Public License v3.0
45 stars 13 forks source link

Python3 Upgrade #423

Open lsrzj opened 3 years ago

lsrzj commented 3 years ago

I'm making some code changes, besides I don't know Python, but I'm learning and trying to contribute to your project making it compatible with Python 3. Please check if my contributions are valuable and correct, the problem I'm facing now is when trying to play the score in midi, it says: "Couldn't read first 12 bytes of audio data" and, by now, I don't know how to correct this.

An issue that I faced is when trying to export to a midi file, the file dialog beggins to open, but it freezes and then comes this fatal error: Fatal Python error: PyEval_SaveThread: the function must be called with the GIL held, but the GIL is released (the current Python thread state is NULL) Python runtime state: initialized

and it refers to this code snippet: fname = QFileDialog.getSaveFileName(parent=self, caption=caption, directory=directory, filter="DrumBurp files (*.mid)")

I have no information on how to correct this, after googling a lot.