search

WhatsApp / WhatsApp-Business-API-Setup-Scripts

The scripts related to setting up WhatsApp business API
MIT License
404 stars 425 forks source link

Explicitly specify command for k8s spec #86

Closed nemani closed 1 year ago

facebook-github-bot commented 1 year ago

@nemani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jsravn commented 1 year ago

LGTM.

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D43837079

facebook-github-bot commented 1 year ago

@nemani merged this pull request in WhatsApp/WhatsApp-Business-API-Setup-Scripts@86e8e187aa0466c299cdd24d3b4cfada461ccee0.

bmm-alc commented 1 year ago

Hello,

that would be useful for people tracking the project to explain rather why you trying to do rather what you did in the commit. I don't get why you use a script called launch_within_docker.sh in a container in k8s. Could you elaborate ?

Thanks

nemani commented 1 year ago

We use an bash script as CMD entrypoint to our containers. This script is called launch_within_docker.sh. Due to a change in containerd.io-1.6.18 & go 1.19.6 we need to use absolute path to the script. This should not be a requirement once for new patches released by us. But in the meantime we are changing the template to workaround this. This matches with all the other templates we provide.

bmm-alc commented 1 year ago

Thanks for the reply. It's appreciated.

Have a nice day.

On Tue, Mar 7, 2023 at 12:34 PM Arjun Nemani @.***> wrote:

We use an bash script as entrypoint to our containers. This script is called launch_within_docker.sh. Due to a change in containerd.io-1.6.18 https://github.com/containerd/containerd/releases/tag/v1.6.18 & go 1.19.6 https://github.com/golang/go/issues/43724 we need to use absolute path to the script. This should not be a requirement once for new patches released by us. But in the meantime we are changing the template to workaround this. This matches with all the other templates we provide.

— Reply to this email directly, view it on GitHub https://github.com/WhatsApp/WhatsApp-Business-API-Setup-Scripts/pull/86#issuecomment-1458012652, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATF2SCU56QTZCBILY7QPSJDW24MNVANCNFSM6AAAAAAVRFMN7E . You are receiving this because you commented.Message ID: @.*** com>