search

WhatsApp / erlang-language-platform

Erlang Language Platform. LSP server and CLI.
https://whatsapp.github.io/erlang-language-platform/
Apache License 2.0
209 stars 16 forks source link

Set both include_dirs and include_path for rebar3 deps #13

Closed filmor closed 4 months ago

filmor commented 7 months ago

This is a follow up of https://github.com/WhatsApp/eqwalizer/pull/49 to set both the include_dirs and include_path entries for apps that are created from rebar3 build-info.

Explanation: https://github.com/WhatsApp/eqwalizer/pull/49#issuecomment-1847451510

perehonchuk commented 6 months ago

@filmor thanks for your contribution. We already set include_path here. The only difference between your PR and what we have now is that you setting the include_path for deps. I am not sure I understand your usecase, but could you try setting the include_path for deps in Rebar::new like we do for apps and check if it helps?

facebook-github-bot commented 4 months ago

@robertoaloi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 months ago

@robertoaloi merged this pull request in WhatsApp/erlang-language-platform@b33b594fb33ecfb30261b9ce024974847d8cc33e.

robertoaloi commented 4 months ago

Thanks for your contribution @filmor and sorry for the delay!