search

WhatsApp / erlang-language-platform

Erlang Language Platform. LSP server and CLI.
https://whatsapp.github.io/erlang-language-platform/
Apache License 2.0
242 stars 19 forks source link

Some minor bpaf fixes #4

Closed pacak closed 1 year ago

pacak commented 1 year ago

Describe your changes

minor improvements to bpaf code, it should be possible to clean it up more with 0.9 branch - show help by default, etc.

--experimental flag seems a bit strange. Name and help suggest that it will enable experimental diagnostics, while value it produces and how it is later used suggests that experimental diagnostics will be disabled:

crates/elp/src/bin/elp_parse_cli.rs:    cfg.disable_experimental = args.experimental_diags;
crates/elp/src/bin/lint_cli.rs:            cfg.disable_experimental = args.experimental_diags;
facebook-github-bot commented 1 year ago

@alanz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@alanz merged this pull request in WhatsApp/erlang-language-platform@2b07563531534dfde5aabe28117f690a4c12f430.