search

WhatsApp / erlfmt

An automated code formatter for Erlang
Apache License 2.0
412 stars 52 forks source link

Ensure the correct IO opts when reading from stdin #335

Closed filmor closed 2 years ago

filmor commented 2 years ago

Since the io:setopts call is done in the escript main, it doesn't carry over to rebar3 fmt and breaks rebar3 fmt -. By adjusting the standard_io opts when actually reading from stdin and reverting back, this should work now.

facebook-github-bot commented 2 years ago

Hi @filmor!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

michalmuskala commented 2 years ago

Thank you! :heart: