search

WhatsApp / stickers

This repository contains the iOS and Android sample apps and API for creating third party sticker packs for WhatsApp.
Other
2.72k stars 1.7k forks source link

[iOS] Error after trying to update a pack #599

Open c42sx opened 4 years ago

c42sx commented 4 years ago

Some users are complaining that the packs are not being updated anymore, if the user sends a new version of the pack to the WhatsApp, WhatsApp saves as a new pack and does not ask to update the existing pack. After the user saves the new version, the old version becomes some kind of ghost and the stickers disapears. If I try to access the old version, there is a eternal loading. I verified the pack ID and it is always the same. Here you can see the two versions of the same pack, the updated one with the stickers and the old one without stickers https://imgur.com/awDcSbn When I try to use the old version: https://imgur.com/HBKhO4E

aj8496 commented 4 years ago

any update on this....

c42sx commented 4 years ago

no update. Users keep sending emails complaining about this issue.

Zandor300 commented 4 years ago

@amrit-1901 Could you take a look at this? (cc @simonzhexu)

aj8496 commented 4 years ago

please give update on this Error...!

simonzhexu commented 4 years ago

Sorry for the delay guys, looking.

amrit-1901 commented 4 years ago

hmm, I can't reproduce this. @c42sx What do you have to change on the sticker pack to repro?

c42sx commented 4 years ago

I dont need to do anything special, just add a pack as normal, then add a new sticker to the pack and try to add it again to WhatsApp, there will be no update button, the only option is save, like when you add a new pack.

amrit-1901 commented 4 years ago

Do you mind sending your app to me by email (amrit1901@fb.com)? I can't reproduce with my own project by doing the steps you mentioned, so maybe your app might give some more clues.

markkorput commented 4 years ago

When I try to update a previously added stickerpack on iOS, I don’t even get an option the save a new pack, like @c42sx, I only get the option to remove the existing stickerpack (big red Remove button). When confirming the remove action, the existing pack is removed but the update is NOT added.

So the UX for my app’s user is; save (in my app) —> confirm remove (in whatsapp) —> go back to original app —> save again (in my app) --> Confirm adding sticker pack (in whatsapp).

.............

(To reproduce; simply try it with the iOS example app)

Zandor300 commented 4 years ago

@amrit-1901 What is the workflow supposed to be? Should it just detect that the pack is different?

c42sx commented 4 years ago

Do you mind sending your app to me by email (amrit1901@fb.com)? I can't reproduce with my own project by doing the steps you mentioned, so maybe your app might give some more clues.

already sent you the email. thanks

amrit-1901 commented 4 years ago

@c42sx Thanks, I'll take a look. @Zandor300 Yeah, it should. The "Update" button should appear instead of the "Save" one

aj8496 commented 4 years ago

@c42sx Thanks, I'll take a look. @Zandor300 Yeah, it should. The "Update" button should appear instead of the "Save" one

@amrit-1901 there is no update button is appearing, only save button is there for existing sticker pack

amrit-1901 commented 4 years ago

ok, so I've taken a look at this and it seems that you are setting a different sticker pack id every time "Add to WhatsApp" is tapped. The sticker pack id should remain the same even if stickers are removed or deleted. I've used the "Sticker Maker" app to debug this btw.

c42sx commented 4 years ago

ok, so I've taken a look at this and it seems that you are setting a different sticker pack id every time "Add to WhatsApp" is tapped. The sticker pack id should remain the same even if stickers are removed or deleted. I've used the "Sticker Maker" app to debug this btw.

I already double checked this, and did it again now that you mentioned it. We are sending the same pack id. I think the problem is WhatsApp because when we do send the pack again, the old pack appears as blank. If we were sending with a new pack id, both packs should appear with all the stickers. You can see the error in the old pack in this picture https://imgur.com/HBKhO4E . And it is really strange that a lot of stickers apps are having the same problem out of the blue.

alexmorral commented 4 years ago

We are also experiencing this issue and we also think is WhatsApp's problem. We haven't updated our app in a relative long time and the issue suddenly appeared (maybe a WhatsApp update?). One of our users sent us this image. EDIT: He tells us that when he tries to update the pack, the ghost one appears without the stickers, and a new one is created.

amrit-1901 commented 4 years ago

ok, yeah, it's actually our fault... sort of. It looks like iOS 13 is preventing us from using third party app bundle identifiers. The reason why I could't reproduce it is because I made my sticker app with the same team as the WhatsApp main app. This is actually a non-trivial problem to solve, but I'll keep you posted for any updates.

c42sx commented 4 years ago

hi, any news about this issue?

vOwl commented 4 years ago

Hi, Any news about it? @amrit-1901

nikowiss commented 4 years ago

Android has the sticker pack version number that allows packs to be updated inside WhatsApp. But WhatsApp on iOS seems to ignore the version number and adds instead a new pack (same identifier) which leaves the previously added pack as an empty "ghost pack". I'd really like to have a solution for that.

shayshtern commented 4 years ago

Anyone get to fix it? Same here on iPhone XS iOS 13.5. I’m using Sticker Maker for iOS.

gyeongnz commented 3 years ago

Any news? Same here on Whatsapp version 2.21.30.20 for iOS image

BattleShipPark commented 3 years ago

Do you have any updates?

sofyafreyman commented 3 years ago

Hey guys, we are aware of this bug, it happens on iOS 13+ due to changes in API. I will prioritize finding a fix and will update you as soon as I can. Thanks for your patience

alejoacostaa commented 3 years ago

Any updates? As of today, this keeps happening.

jluquer commented 1 year ago

Still happening, any update?

perpeer commented 6 months ago

Any update ? It still is not working correctly.

omerfarukozturk commented 6 months ago

Hi @perpeer, could you share more details? such as; Device, iOS version, Which app you're using to import (Sticker Maker?) or also screen recording would be helpful.

whiterose199187 commented 5 months ago

hello @omerfarukozturk

this problem still exists on iOS.

if you try to add stickers to an existing pack (same identifier, icon image). it creates an extra pack where 1 pack contains the images (earlier ones when pack was first created) and the second one is blank

Exactly as reported https://github.com/WhatsApp/stickers/issues/599#issuecomment-784107260

Is there any plan to address this?

The way I am exporting stickers is by creating a json as mentioned https://github.com/WhatsApp/stickers/tree/main/iOS#structure-of-the-json-file-that-is-sent-to-whatsapp

The goal is to add new stickers to an existing pack, how can this be done on iOS?

iphone 12, iOS 17.3.1 WhatsApp Version: 2.24.5.75

whiterose199187 commented 5 months ago

following up on this again, are there any plans to address this?