WheatonCS / Lexos

Python/Flask-based website for text analysis workflow. Previous (stable) release is live at:
http://lexos.wheatoncollege.edu
MIT License
120 stars 20 forks source link

Display of uploaded filenames is not fixed #259

Closed akuisara closed 8 years ago

akuisara commented 9 years ago

On Scrubber page, if a user uploads some files inside the additional options area, the filenames showing on screen can be moved around by expanding and hiding certain option. Also some of them overlap with each other as shown below:

screen shot 2015-09-30 at 11 00 49 pm screen shot 2015-09-30 at 11 01 44 pm

.

scottkleinman commented 9 years ago

I suspect this issue affects Multicloud as well, though it may be less apparent because that page is less cluttered. We should probably try a fix for the upload css in the main css file.

mleblanc321 commented 9 years ago

i noted this awhile ago (thanks for posting sara); however, i couldn't see where we'd make a change;

scottkleinman commented 9 years ago

I've pushed a fix but haven't tested in lots of browsers. If people can do some testing, and it looks all right, we can close this issue.

mleblanc321 commented 9 years ago

MacOS, Chrome v45.02x if the uploaded filename is long (e.g., DAZ_consolidations.txt) the uploaded filename appears on the next line and overwriting the next label); note that DAZ_lemma.txt fits in ok for stopwords/consolidations/lemma sections, but longer uploaded names appear on the next line);

so, if i upload DAZ_consolidations.txt for Consolidations, the filename appears on top of the (subsequent) "Special Characters" label

scottkleinman commented 9 years ago

I had a feeling that fix was too easy. But this gives me something to go on. I'll see what I can do...

scottkleinman commented 9 years ago

Grrrr.... I've pushed another fix, but it was not easy. I ended up having to change the layout, placing the file name on the same line as the legend. I hope you like the effect. It's not a perfect solution: file names longer than about 45 characters will still wrap to the next line, but file names that long should be pretty rare. Please test.

mleblanc321 commented 9 years ago

umm, did you really push a change?

scottkleinman commented 9 years ago

Apparently, it didn't work. I've pushed it again.

mleblanc321 commented 9 years ago

looks good on my mac laptop; i'll check at the office also; good job, scott

scottkleinman commented 9 years ago

Great! You might want to pull one more time. I've added clipping for file names greater than 35 characters long to keep long file names on one line.

mleblanc321 commented 9 years ago

ha! was just headed there; thanks very much scott;

mleblanc321 commented 8 years ago

i think we can close this issue (?)

scottkleinman commented 8 years ago

It's worth testing this in the Bootstrap version with various browsers and screen sizes, but this should be fixed.

scottkleinman commented 8 years ago

Upload seems to be working, so I'll close this issue.