search

Wheellog / Wheellog.Android

App for EUC on Android. Various popular unicycle manufacturers are supported.
GNU General Public License v3.0
61 stars 20 forks source link

VeteranAdapter Kotlin refactor #466

Closed nathan234 closed 1 year ago

nathan234 commented 1 year ago

Preparing this for the new Veteran Lynx

paymicro commented 1 year ago

why is this necessary?

nathan234 commented 1 year ago

It is not necessary.

nathan234 commented 1 year ago

But, the new wheel coming out will require changes, since the new high voltage is 151.2 Volts on the Lynx

paymicro commented 1 year ago

I don't see any reason why a new model can't be added without refactoring

nathan234 commented 1 year ago

You're right, it doesn't. So you don't want this code merged then?

paymicro commented 1 year ago

Yes. A clear reason is needed for such a change. As you can see, all adapters are written in java. This is an important code.

nathan234 commented 1 year ago

So would you prefer a Java PR to change the Veteran Adapter? Perhaps a draft? The voltage is going to be incorrect on the Lynx