search

WheezyE / Winelink

Installation scripts for running Winlink (RMS Express/Trimode & VARA) on non-Windows computers. Wine & Box86 make this project possible.
68 stars 18 forks source link

Fix for Ubuntu/Mint winehq downloads. #53

Closed nomore1007 closed 1 year ago

nomore1007 commented 1 year ago

added sudo wget -O /etc/apt/keyrings/winehq-archive.key https://dl.winehq.org/wine-builds/winehq.key in place of the current key download.

WheezyE commented 1 year ago

I believe you are correct about this new location for the WineHQ repo's GPG key: It looks like they fixed a bug I reported to WineHQ regarding incorrect pointing to the winehq .sources file. I'll merge this and also update my sed kludge a few lines below.

More info: In the past, there was a bug with WineHQ where the /etc/apt/sources.list.d/winehq-${VERSION_CODENAME}.sources file for any-given version had either Signed-By: /etc/apt/keyrings/winehq-archive.key OR Signed-By: /usr/share/keyrings/winehq-archive.key listed (depending on the version). I put a kludge in the script make the .sources file always point to /usr/share/ but it looks like WineHQ fixed this bug. The official WineHQ documentation at the time also said to put the key file into /usr/share/ , but it looks like that isn't the case anymore. I'll merge this patch and change to kludge to point to /etc/apt/ instead of /usr/share/. It looks like WineHQ put up a new blurb on their Ubunutu page about this very problem here.

WheezyE commented 1 year ago

Huh, even doing everything correctly, my x64 Linux Mint still fails sometimes for some reason? I'll look into this more later, but but it might just be most stable to have the GPG key saved to both /etc/apt and /usr/share/ for edge-cases where the .sources file points to the wrong place. EDIT: I've decided to stick with the sed method but use /etc/apt/ as the default location for the GPG key since that is what WineHQ seems to be doing.

WheezyE commented 1 year ago

Oh that's right, I've been experimenting with the debian section of my script on accident instead of the mint section too. I'll update both with this fix.

Thank you for a good catch / for looking out and for looking into this!

WheezyE commented 1 year ago

Made sure the non-ARM Debian & Ubuntu installers were updated with this fix too 0b6f04e125ee1e05050bc281b31347ba8c1a64e6