add codename detection to fix distribution fails

[SpudGunMan]

suggestion to handle mint and ubuntu differences on install. mint has a package installer dedicated for codename management. tested against 2(2x.x)Mint|Ubuntu with success on all platforms.

[WheezyE]

Thank you for looking into these platforms. I’ll try testing them out and see how we might implement them. My coding time to add things a review PR’s is a bit limited at the moment but I’ll jump back in when I get a chance.

On Mon, Nov 7, 2022 at 8:17 AM Kelly @.***> wrote:

tested on pi4 and mint-vanessa vm appears working. assume the other branches fall in line but..

I have two things in this change which I kept as small as possible. First is the codename detection I didnt look at the script to see why exactly but the existing codename isn't working for Vanessa detection. This seems more platform stable overall and might be worth change? you or I can remove that source request if so?

also feel free to just use the idea and meld it in if you have a better idea to rework this entire section

if you $ cat /etc/lsb-release you can see what else is available for OS detection and since your just scripting for Debian should always work.

— Reply to this email directly, view it on GitHub https://github.com/WheezyE/Winelink/pull/54#issuecomment-1305765079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCGVPXGEAAHPGADH4E7GKLWHEMO5ANCNFSM6AAAAAARYWCGVA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[WheezyE]

Thank you for your help and ideas. I’ll try to review these relatively soon although I don’t have a timeline yet. Would you be able to squash your commits? (GitHub desktop can help with squashing and pushing)

On Mon, Nov 7, 2022 at 4:08 PM Kelly @.***> wrote:

new code in testing on multiple platforms I think is tighter.. since this is the end of the line for OS hunting we have room to just move variables like this

— Reply to this email directly, view it on GitHub https://github.com/WheezyE/Winelink/pull/54#issuecomment-1306344698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCGVPQPUK6N6WMOS6NC6IDWHGDVDANCNFSM6AAAAAARYWCGVA . You are receiving this because you commented.Message ID: @.***>

[SpudGunMan]

just a comment as I am using this internally - I find random apt failures due to dependency order issues sometimes randomly. re-running the script a second time hasn't let me down yet.

[SpudGunMan]

this also appears to fix a 2023 issue with winehq

[SpudGunMan]

Let me know if you want me to resolve conflicts. Easy to discard the lines for AHK

Also, this patch ideally also should remove the old wine key inclusion on pi, I didn't remove it to keep things flexible, but long term, This needs a little more clean up.

Also feel free to just dump this (but still it needs fixed)

As this fork:branch is being used by a few support threads I will wait for any direction to change.

Welcome back :)

[WheezyE]

• 47f532c was already fixed in your #59 PR that I've just merged (d48fda13a704e7e14629460155816f9b31e270b3). This is redundant.
• 823b86a is a bit kludgy since it duplicates the GPG key. It was a good catch of the WineHQ .sources file errors which caused x64/x86 Debian/Ubuntu installs to fail. I merged nomore1007's #53 PR and added a failsafe with sed too, so we won't need this patch at this point.

[WheezyE]

Also, this patch ideally also should remove the old wine key inclusion on pi, I didn't remove it to keep things flexible, but long term, This needs a little more clean up.

The wine installs in the Pi (ARM) sections don't use winehq GPG keys (since they just download the packages directly with wget and dpkg them manually). This is because there isn't a 'kosher' way to install i386 wine on arm systems so we have to kind of hack it together like that. https://github.com/WheezyE/Winelink/blob/0b6f04e125ee1e05050bc281b31347ba8c1a64e6/install_winelink.sh#L69

I think you might be confusing the Pi sections with the x86/x64 raspbian section https://github.com/WheezyE/Winelink/blob/0b6f04e125ee1e05050bc281b31347ba8c1a64e6/install_winelink.sh#L160 The x86/x64 sections do deal with GPG keys since I wanted to keep the installation as clean as possible where I could and use the official Wine repo's for non-ARM systems.

[WheezyE]

482de08733229145579e81277b10c233c6abc2a5 I'm not super sure what this part is doing, but I think we probably fixed it with the correct key location stuff for the .sources file for ubuntu/debian (#53). Would you mine re-testing the machines that seemed broken using the latest version of the winelink script from today (0b6f04e125ee1e05050bc281b31347ba8c1a64e6 - or later)?

Welcome back :)

Thank you! :) I really appreciate that :)

[SpudGunMan]

I didnt understand the question on the first 482de no highlight of code. yes I think you got it worked out either way.

I will get my test environment reset and tinker with that friday

[SpudGunMan]

No news is good news so far it looks like even better compatibility. exciting news!

I need to give a rest for hosting limits on downloading these same files 100 times a hour ;)

So far so good will test over weekend as well.

Do you need any of my fork's or got it all? I will close any and delete branches and fork when dust settles to tidy up.

[WheezyE]

I think if everything is working, and since we've got the parts merged that we need, I think you can discard the fork if you like.

[WheezyE]

I'll close this PR if your testing with the latest Winelink works ok.

[SpudGunMan]

I am using the latest yes