search

WheezyE / Winelink

Installation scripts for running Winlink (RMS Express/Trimode & VARA) on non-Windows computers. Wine & Box86 make this project possible.
68 stars 18 forks source link

feature patch: allow local download if megadownload fails #56

Closed SpudGunMan closed 1 year ago

SpudGunMan commented 1 year ago

the mega hosting isnt a fan of scripts.

this is a patch to allow hunting the downloads folder first, before mega-download fails and script crashes out.

I didnt add any comments or details to the header or readme about this ideally documented as well for end user

kept minimal change suggestion.

the || error didnt work anyway no trap'n

WheezyE commented 1 year ago

I like fail-safes, and I like the idea behind this, but the downloads cache gets cleared by the script after each install (to free up disk space for the user) https://github.com/WheezyE/Winelink/blob/0b6f04e125ee1e05050bc281b31347ba8c1a64e6/install_winelink.sh#L1045

_Confusing code note: The VARA Update script is used as the main VARA install procedure (see: function run_installvara()). This was done so that we could have just one area of the Winelink script that controlled VARA installation for easier code maintenance in the future._

I'd like to keep these cleanups so we don't have users installing older VARA on accident or having files on disk they'll never use. And since there won't be any cached files to draw from in event of megadl failure, I unfortunately don't think this will work.

WheezyE commented 1 year ago

If it's ok with you, I think I'll close this PR. I'll look out for another way to get VARA from mega though or maybe some other official mirror if VARA's author decides to host the files officially somewhere else