search

WhelanB / RoR2-Discord-RP

Risk of Rain 2 mod to introduce support for Discord Rich Presence
https://thunderstore.io/package/WhelanB/DiscordRichPresence/
2 stars 5 forks source link

Getting to run on SOTV #14

Open DarkKronicle opened 2 years ago

DarkKronicle commented 2 years ago

This allows the mod to run with the latest release of Survivors of the Void. Haven't fully tested the join option, but it should work.

Assets for the new stages have not been added yet.

DarkKronicle commented 2 years ago

Also, would you consider adding a license to the project? This would make it easier for some more contributions. You may want to consider GPL-v3, MPL-v2, or MIT.

DarkKronicle commented 2 years ago

Added new images

ZANdewanai commented 2 years ago

i have more image assets if getting them is a pain, was for my own fix of a rich presence but seems this one will be easier to use

ZANdewanai commented 2 years ago

if the rich presence doesnt show also, try on line 38

client = new DiscordRpcClient("954183647328620554", -1, null, true, pipe);

to use mine, noticed it didnt have a client for it so yeah though idk if it works without one

DarkKronicle commented 2 years ago

It doesn’t work without that ID, but I left it out because the author had it removed. Tho idk if they want to change that

ZANdewanai commented 2 years ago

yeah, could imagine, maybe they just took it out since they didnt want to work more on it?, or suppose until it had the updated assets

ZANdewanai commented 2 years ago

would be nice to have the small image working too with the survivors on it, i dont know much about this to call the assets in line 327

DarkKronicle commented 2 years ago

Oh yeah they removed it on October 8 in the most recent commit. Tho idk if I can fork and publish since there is no license

DarkKronicle commented 2 years ago

i have more image assets if getting them is a pain, was for my own fix of a rich presence but seems this one will be easier to use

Want to add me on discord? DarkKronicle#9102

WhelanB commented 2 years ago

Thanks for this! was hoping to get to updating the handlers today and spotted you'd opened the PR - will take a look now and get it merged + released. I'll update the app I have registered on Discord with the new assets and push a new release to Thunderstore once it all looks good to go!

ZANdewanai commented 2 years ago

you can use these stage images too if you like as i told dark kronicle too, is in the stage folder https://github.com/Zanzancomms/RoR2-Rich-Presence