WheteThunger / MonumentAddons

Add entities, spawn points and more to monuments
https://umod.org/plugins/monument-addons
MIT License
5 stars 9 forks source link

Automatically name static telephones #33

Closed m-hynek closed 2 years ago

m-hynek commented 2 years ago

29

Monuments

Freight Transit Line

Underwater Labs

I am not sure if DoServerDestroy() is called on Telephone instance when unloading MA. If not, we should add TelephoneManager.DeregisterTelephone(phoneController) to PreEntityKill()

I feel like code needs some improvements, but im pretty happy with functional result

Edit: Added dynamic monuments support

m-hynek commented 2 years ago

Thank you for detailed review!

Working (and hopefuly not bothering you much) on project like MA is great opportunity for me to learn and improve in C# and Rust plugin making. I was developing website applications in PHP for almost decade, so this is whole new world. Even if I have solid programming background, I have no real idea what I am doing most of the time, its all guessing (I still can't believe my 2 little plugins got approved on Umod lol). So thank you for keeping me around, I learned a lot in past weeks.

I will push changes tomorrow, hopefully.

m-hynek commented 2 years ago

Nono, thanks for your patience!