WhichBrowser / Parser-PHP

Browser sniffing gone too far — A useragent parser library for PHP
http://whichbrowser.net
MIT License
1.79k stars 240 forks source link

Add Mac OS 11 (Big Sur) #621

Closed summercms closed 3 years ago

summercms commented 3 years ago

See github issue: https://github.com/WhichBrowser/Parser-PHP/issues/620

macOS Big Sur (version 11) details: https://en.wikipedia.org/wiki/MacOS_Big_Sur

Updated testing repo: https://github.com/ayumi-cloud/Parser-PHP-v3.x.x/releases/tag/3.0.1

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.02%) to 99.976% when pulling 8d2bb32192c70e0b12a6e0ce97e13721384cea16 on ayumi-cloud:mac-os-11 into 880b9fa797401d14b28956442944c3daa70240ff on WhichBrowser:master.

summercms commented 3 years ago

Forgot to mention, the nickname is already added to the repo, see commit: https://github.com/WhichBrowser/Parser-PHP/commit/e60f8255d5b8c9a2a8eb6307e7e5996f6f94fe77

https://github.com/WhichBrowser/Parser-PHP/blob/e60f8255d5b8c9a2a8eb6307e7e5996f6f94fe77/src/Analyser/Derive.php#L488-L494

necenzurat commented 3 years ago

Hello,

There is a mismatch, Safari says it's nickname is Catalina and Chrome just returns null instead of Big Sur.

Also the version of the OS on Chrome is 11.2.3 and Safari is 10.15.6

Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.82 Safari/537.36
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

Running:

Screenshot 2021-03-14 at 18 33 22