search

WhichBrowser / Parser-PHP

Browser sniffing gone too far — A useragent parser library for PHP
http://whichbrowser.net
MIT License
1.79k stars 240 forks source link

Add extra browser specific http headers #636

Closed summercms closed 3 years ago

summercms commented 3 years ago

The headers that tend to store the real useragents are:

Opera Mini - HTTP_X_OPERAMINI_PHONE_UA Opera Mini (legacy) - HTTP_X_OPERAMINI_FEATURES Opera Mobile - HTTP_DEVICE_STOCK_UA SkyFire Browser - HTTP_X_SKYFIRE_PHONE Bolt Browser - HTTP_X_BOLT_PHONE_UA UCBrowser - HTTP_X_UCBROWSER_DEVICE_UA Common Browser Proxies - HTTP_X_ORIGINAL_USER_AGENT Web Forms - HTTP_X_DEVICE_USER_AGENT

This pr adds SkyFire Browser and Bolt Browser to the analyse browser specific headers section.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.671% when pulling e0f27edcb2242f2023c989b648d39a8d3a85167d on ayumi-cloud:http-headers into da24adc4f4f26002673d236e69b91a10f2fd594c on WhichBrowser:master.

summercms commented 3 years ago

Skyfire

https://github.com/WhichBrowser/Parser-PHP/blob/da24adc4f4f26002673d236e69b91a10f2fd594c/tests/data/mobile/browser-skyfire.yaml#L1-L12

https://github.com/WhichBrowser/Parser-PHP/blob/609ba5e121d6f06a641dc1f797c1bd3efaaf103d/src/Analyser/Header/Useragent/Browser.php#L2028-L2039

Bolt

https://github.com/WhichBrowser/Parser-PHP/blob/3ba0526403482aa96114f18d06466fab260f9b15/tests/data/desktop/browser-other.yaml#L362-L365

https://github.com/WhichBrowser/Parser-PHP/blob/460636bd7a6db61ef0322e84cd4bd4284b3d8396/data/applications-browsers.php#L51

summercms commented 3 years ago

Closing already merged into the repo and test cases are currently working.