search

Whinarn / MeshDecimator

A mesh decimation library for .NET and Unity.
MIT License
288 stars 47 forks source link

Quadric vs Quadratic #1

Closed amirebrahimi closed 6 years ago

amirebrahimi commented 6 years ago

Minor, but I think you meant to call this class FastQuadricMeshSimplification, no?

https://github.com/Whinarn/MeshDecimator/blob/707ffc5c77bacbc99cda1ba01127e8d53092af21/MeshDecimator/Algorithms/FastQuadraticMeshSimplification.cs#L50

Whinarn commented 6 years ago

Ah, yes. You are correct.

I will resolve this in a few hours. Thank you.

Whinarn commented 6 years ago

This has now been resolved with a breaking change. Thanks again!

amirebrahimi commented 6 years ago

Thanks! FYI - DLLs weren't regenerated for the Unity example. Not sure if that matters though in relation to #3

Whinarn commented 6 years ago

Yet again you are correct, I totally missed that part.

I also stumbled upon another silly thing, which was that the meta files for the Unity example project was being ignored by the .gitignore I had for the VisualStudio project in the root directory. So I resolved that as well. I cannot believe that I missed that.