search

Whinarn / UnityMeshSimplifier

Mesh simplification for Unity.
MIT License
1.76k stars 277 forks source link

References update #34

Closed is3D-1 closed 4 years ago

is3D-1 commented 4 years ago

Reference array is not initialized properly for a degenerated triangle when using smart linking Smart linking can merge two very close triangle vertices together. For instance a triangle T(a,b,c) could become T(a,a,c) after smart linking. The UpdateReferences() function do not update the refs[] array correctly in this case because it overwrites the same ref cell twice and leaves the second ref cell not initialized because the indexer is updated only at the end of the function.

Whinarn commented 4 years ago

Nice find! I will test this out after work in a few hours.

is3D-1 commented 4 years ago

I agree with the proposed changes.

Whinarn commented 4 years ago

I agree with the proposed changes.

No worries. If you looked in the files tab there would have been buttons to commit the suggested changes or add them in batch to commit them all at once. I took care of it now for you.

I think that you also unintentionally closed the pull request, so I reopened it.

Whinarn commented 4 years ago

Thanks again for contributing!

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 2.3.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: