search

Whisky-App / Whisky

A modern Wine wrapper for macOS built with SwiftUI
https://getwhisky.app
GNU General Public License v3.0
12.54k stars 263 forks source link

[Bug]: Icon extraction can sometimes fail causing Whisky to crash #119

Closed sheyaln closed 1 year ago

sheyaln commented 1 year ago

Description

I was able to Import a bottle (made using the Game Porting Toolkit guide on Apple Gaming Wiki) successfully. Unfortunately, once I install anything within that bottle, Whiskey starts crashing immediately after selecting the bottle in the sidebar.

A report appears when Whiskey is launched again after a crash. The full report text is posted under "logs" in this issue.

Windows applications I attempted to install (in a fresh bottle Win10, every time):

Steps to reproduce

  1. Install Game Porting Toolkit using the aforementioned guide.
  2. Open Whiskey and import directory of Wine prefix created at this step: Game Porting Toolkit - Wineprefix.
  3. Confirm that the bottle is editable via Whiskey without issues.
  4. Install a Windows application in that bottle (either via Whiskey GUI or via command line).
  5. Close Whiskey and reopen.
  6. Select the imported bottle from the sidebar.

Expected behaviour

The bottle remains configurable via the Whiskey GUI

Logs

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               Whisky [96610]
Path:                  /Applications/Whisky.app/Contents/MacOS/Whisky
Identifier:            com.isaacmarovitz.Whisky
Version:               pre-0.3.0 (13)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2023-06-16 19:53:42.3850 -0400
OS Version:            macOS 14.0 (23A5257q)
Report Version:        12
Anonymous UUID:        D1187C6A-C881-0888-20FE-2428AFBF86D2

Time Awake Since Boot: 7200 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BREAKPOINT (SIGTRAP)
Exception Codes:       0x0000000000000001, 0x0000000187a0a1a0

Termination Reason:    Namespace SIGNAL, Code 5 Trace/BPT trap: 5
Terminating Process:   exc handler [96610]

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   Foundation                             0x187a0a1a0 Data._Representation.subscript.getter + 580
1   Whisky                                 0x102ff6470 0x102fb0000 + 287856
2   Whisky                                 0x102fd2e90 0x102fb0000 + 142992
3   Whisky                                 0x102ff2860 0x102fb0000 + 272480
4   SwiftUI                                0x1b1eca16c 0x1b0b15000 + 20664684
5   SwiftUI                                0x1b1534360 0x1b0b15000 + 10613600
6   SwiftUI                                0x1b1ef3398 0x1b0b15000 + 20833176
7   SwiftUI                                0x1b1ef2b10 0x1b0b15000 + 20830992
8   SwiftUI                                0x1b21fedbc 0x1b0b15000 + 24026556
9   SwiftUI                                0x1b2201be8 0x1b0b15000 + 24038376
10  SwiftUI                                0x1b2201c40 0x1b0b15000 + 24038464
11  CoreFoundation                         0x18642f9f4 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 36
12  CoreFoundation                         0x18642f8e0 __CFRunLoopDoObservers + 532
13  CoreFoundation                         0x18642e5a0 CFRunLoopRunSpecific + 676
14  HIToolbox                              0x190816290 RunCurrentEventLoopInMode + 292
15  HIToolbox                              0x190815f20 ReceiveNextEventCommon + 220
16  HIToolbox                              0x190815e24 _BlockUntilNextEventMatchingListInModeWithFilter + 76
17  AppKit                                 0x189b139f8 _DPSNextEvent + 660
18  AppKit                                 0x189b12a3c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 716
19  AppKit                                 0x189b0658c -[NSApplication run] + 476
20  AppKit                                 0x189add7fc NSApplicationMain + 880
21  SwiftUI                                0x1b0bbd3cc 0x1b0b15000 + 689100
22  SwiftUI                                0x1b219a410 0x1b0b15000 + 23614480
23  SwiftUI                                0x1b18b3308 0x1b0b15000 + 14279432
24  Whisky                                 0x102fe5af8 0x102fb0000 + 219896
25  dyld                                   0x185fd9058 start + 2224

Thread 1:
0   libsystem_pthread.dylib                0x18634de28 start_wqthread + 0

Thread 2:
0   libsystem_pthread.dylib                0x18634de28 start_wqthread + 0

Thread 3:
0   libsystem_pthread.dylib                0x18634de28 start_wqthread + 0

Thread 4:: com.apple.NSEventThread
0   libsystem_kernel.dylib                 0x186312994 mach_msg2_trap + 8
1   libsystem_kernel.dylib                 0x186324e10 mach_msg2_internal + 80
2   libsystem_kernel.dylib                 0x18631b5d0 mach_msg_overwrite + 476
3   libsystem_kernel.dylib                 0x186312d18 mach_msg + 24
4   CoreFoundation                         0x1864307e0 __CFRunLoopServiceMachPort + 160
5   CoreFoundation                         0x18642f0c0 __CFRunLoopRun + 1208
6   CoreFoundation                         0x18642e554 CFRunLoopRunSpecific + 600
7   AppKit                                 0x189c3e17c _NSEventThread + 144
8   libsystem_pthread.dylib                0x186353034 _pthread_start + 136
9   libsystem_pthread.dylib                0x18634de3c thread_start + 8

Thread 5:
0   libsystem_pthread.dylib                0x18634de28 start_wqthread + 0

Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x000000000a0d3e22   x1: 0x000000000a0d3e26   x2: 0x0000978c00000000   x3: 0x400060000048a210
    x4: 0x0000000000000004   x5: 0x0000000000002210   x6: 0x000060000048a210   x7: 0x0000000000000001
    x8: 0x000000000000978c   x9: 0xc57e6357c2660016  x10: 0x0000000000000003  x11: 0x0000000000000040
   x12: 0x0000600002522210  x13: 0x00000000001ff800  x14: 0x00000000000007fb  x15: 0x000000009be3706e
   x16: 0x0000000187a09fec  x17: 0x0000000187a09fb0  x18: 0x0000000000000000  x19: 0x0000978c00000000
   x20: 0x000000000a0d3e26  x21: 0x400060000048a210  x22: 0x000000000a0d3e22  x23: 0x0000978c00000000
   x24: 0x0000978c00000000  x25: 0x00000001df31d4b8  x26: 0x00006000007340b0  x27: 0x400060000048a210
   x28: 0x0000000102ff4e40   fp: 0x000000016ce4e870   lr: 0x8d27000102ff6470
    sp: 0x000000016ce4e830   pc: 0x0000000187a0a1a0 cpsr: 0x80001000
   far: 0x00006000027802a0  esr: 0xf2000001 (Breakpoint) brk 1

Binary Images:
       0x103620000 -        0x10362bfff libobjc-trampolines.dylib (*) <3bae9099-c393-341e-a1d1-d29a814e9e91> /usr/lib/libobjc-trampolines.dylib
       0x10374c000 -        0x10378ffff org.sparkle-project.Sparkle (2.4.0) <1be8bc4c-469f-3d72-8c5a-1d2c7900a48b> /Applications/Whisky.app/Contents/Frameworks/Sparkle.framework/Versions/B/Sparkle
       0x102fb0000 -        0x10318ffff com.isaacmarovitz.Whisky (pre-0.3.0) <57afcf99-db2d-359f-acf8-86fcac48cc94> /Applications/Whisky.app/Contents/MacOS/Whisky
       0x187451000 -        0x188053fff com.apple.Foundation (6.9) <8e405dbe-a82f-34c0-94e3-72ae1bc9b374> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
       0x1b0b15000 -        0x1b2810fff com.apple.SwiftUI (5.0.59.1.401) <afb94af7-1b31-35f6-b966-d13a92da705b> /System/Library/Frameworks/SwiftUI.framework/Versions/A/SwiftUI
       0x1863b2000 -        0x186886fff com.apple.CoreFoundation (6.9) <e091b645-7851-3e17-9b9e-8dac876e2dd7> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
       0x1907e6000 -        0x190aa5fff com.apple.HIToolbox (2.1.1) <f1550532-cf27-3c73-bef9-deb5915e2103> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox
       0x189ad9000 -        0x18ac41fff com.apple.AppKit (6.9) <81b7d006-5a82-3837-af26-3b169bbded5f> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
       0x185fd3000 -        0x1860668f3 dyld (*) <c4c87b0c-f89d-3d40-ae04-a6a5cd6f7507> /usr/lib/dyld
               0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???
       0x18634c000 -        0x186358ff3 libsystem_pthread.dylib (*) <989471e7-b5df-3f95-81c5-11bc964fcd4c> /usr/lib/system/libsystem_pthread.dylib
       0x186311000 -        0x18634bff7 libsystem_kernel.dylib (*) <61252d17-2b5d-37b7-bff8-3ca76d8bc349> /usr/lib/system/libsystem_kernel.dylib

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=1.4G resident=0K(0%) swapped_out_or_unallocated=1.4G(100%)
Writable regions: Total=1.2G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.2G(100%)

                                VIRTUAL   REGION 
REGION TYPE                        SIZE    COUNT (non-coalesced) 
===========                     =======  ======= 
Accelerate framework               128K        1 
Activity Tracing                   256K        1 
AttributeGraph Data               1024K        1 
CG image                            80K        5 
ColorSync                          576K       28 
CoreAnimation                      624K       39 
CoreGraphics                        48K        3 
CoreUI image data                 1392K       10 
Foundation                          16K        1 
Kernel Alloc Once                   32K        1 
MALLOC                           275.5M       56 
MALLOC guard page                  288K       15 
MALLOC_MEDIUM (reserved)         600.0M        5         reserved VM address space (unallocated)
MALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)
STACK GUARD                       56.1M        6 
Stack                             10.6M        6 
VM_ALLOCATE                        160K       10 
__AUTH                            1423K      254 
__AUTH_CONST                      23.1M      441 
__CTF                               824        1 
__DATA                             9.9M      429 
__DATA_CONST                      21.3M      447 
__DATA_DIRTY                      1290K      138 
__FONT_DATA                        2352        1 
__LINKEDIT                       869.3M        4 
__OBJC_RO                         70.0M        1 
__OBJC_RW                         2137K        1 
__TEXT                           523.4M      464 
dyld private memory                272K        2 
mapped file                      162.9M       31 
shared memory                      912K       16 
===========                     =======  ======= 
TOTAL                              2.9G     2419 
TOTAL, minus reserved VM space     2.0G     2419 

-----------
Full Report
-----------

{"app_name":"Whisky","timestamp":"2023-06-16 19:53:42.00 -0400","app_version":"pre-0.3.0","slice_uuid":"57afcf99-db2d-359f-acf8-86fcac48cc94","build_version":"13","platform":1,"bundleID":"com.isaacmarovitz.Whisky","share_with_app_devs":0,"is_first_party":0,"bug_type":"309","os_version":"macOS 14.0 (23A5257q)","roots_installed":0,"name":"Whisky","incident_id":"0F4FAC8A-F106-4AB4-B27E-978837402D68"}
{
  "uptime" : 7200,
  "procRole" : "Foreground",
  "version" : 2,
  "userID" : 501,
  "deployVersion" : 210,
  "modelCode" : "MacBookPro17,1",
  "coalitionID" : 1374,
  "osVersion" : {
    "train" : "macOS 14.0",
    "build" : "23A5257q",
    "releaseType" : "User"
  },
  "captureTime" : "2023-06-16 19:53:42.3850 -0400",
  "codeSigningMonitor" : 1,
  "incident" : "0F4FAC8A-F106-4AB4-B27E-978837402D68",
  "pid" : 96610,
  "translated" : false,
  "cpuType" : "ARM-64",
  "roots_installed" : 0,
  "bug_type" : "309",
  "procLaunch" : "2023-06-16 19:53:40.7485 -0400",
  "procStartAbsTime" : 174185376102,
  "procExitAbsTime" : 174223893010,
  "procName" : "Whisky",
  "procPath" : "\/Applications\/Whisky.app\/Contents\/MacOS\/Whisky",
  "bundleInfo" : {"CFBundleShortVersionString":"pre-0.3.0","CFBundleVersion":"13","CFBundleIdentifier":"com.isaacmarovitz.Whisky"},
  "storeInfo" : {"deviceIdentifierForVendor":"0A473987-6532-5384-AE2C-A3E5D9E0DBE0","thirdParty":true},
  "parentProc" : "launchd",
  "parentPid" : 1,
  "coalitionName" : "com.isaacmarovitz.Whisky",
  "crashReporterKey" : "D1187C6A-C881-0888-20FE-2428AFBF86D2",
  "codeSigningID" : "com.isaacmarovitz.Whisky",
  "codeSigningTeamID" : "92S3SG4PTH",
  "codeSigningFlags" : 570520337,
  "codeSigningValidationCategory" : 6,
  "codeSigningTrustLevel" : 4294967295,
  "instructionByteStream" : {"beforePC":"YQIAVOADE6rhAxWq\/XtEqfRPQ6n2V0Kp+F9Bqf9DAZH\/D1\/WIAAg1A==","atPC":"IAAg1CAAINQgACDUIAAg1CAAINQgACDUIAAg1CAAINQgACDUj7oKlA=="},
  "sip" : "enabled",
  "exception" : {"codes":"0x0000000000000001, 0x0000000187a0a1a0","rawCodes":[1,6570418592],"type":"EXC_BREAKPOINT","signal":"SIGTRAP"},
  "termination" : {"flags":0,"code":5,"namespace":"SIGNAL","indicator":"Trace\/BPT trap: 5","byProc":"exc handler","byPid":96610},
  "os_fault" : {"process":"Whisky"},
  "extMods" : {"caller":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"system":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"targeted":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"warnings":0},
  "faultingThread" : 0,
  "threads" : [{"triggered":true,"id":1535234,"threadState":{"x":[{"value":168640034},{"value":168640038},{"value":166627551215616},{"value":4611791571548414480},{"value":4},{"value":8720},{"value":105553121026576},{"value":1},{"value":38796},{"value":14230921101112115222},{"value":3},{"value":64},{"value":105553155203600},{"value":2095104},{"value":2043},{"value":2615373934},{"value":6570418156,"symbolLocation":144,"symbol":"Data._Representation.subscript.getter"},{"value":6570418096,"symbolLocation":84,"symbol":"Data._Representation.subscript.getter"},{"value":0},{"value":166627551215616},{"value":168640038},{"value":4611791571548414480},{"value":168640034},{"value":166627551215616},{"value":166627551215616},{"value":8039552184,"symbolLocation":0,"symbol":"value witness table for Builtin.UnknownObject"},{"value":105553123819696},{"value":4611791571548414480},{"value":4345253440}],"flavor":"ARM_THREAD_STATE64","lr":{"value":10171098287784813680},"cpsr":{"value":2147487744},"fp":{"value":6121908336},"sp":{"value":6121908272},"esr":{"value":4060086273,"description":"(Breakpoint) brk 1"},"pc":{"value":6570418592,"matchesCrashFrame":1},"far":{"value":105553157685920}},"queue":"com.apple.main-thread","frames":[{"imageOffset":6001056,"symbol":"Data._Representation.subscript.getter","symbolLocation":580,"imageIndex":3},{"imageOffset":287856,"imageIndex":2},{"imageOffset":142992,"imageIndex":2},{"imageOffset":272480,"imageIndex":2},{"imageOffset":20664684,"imageIndex":4},{"imageOffset":10613600,"imageIndex":4},{"imageOffset":20833176,"imageIndex":4},{"imageOffset":20830992,"imageIndex":4},{"imageOffset":24026556,"imageIndex":4},{"imageOffset":24038376,"imageIndex":4},{"imageOffset":24038464,"imageIndex":4},{"imageOffset":514548,"symbol":"__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__","symbolLocation":36,"imageIndex":5},{"imageOffset":514272,"symbol":"__CFRunLoopDoObservers","symbolLocation":532,"imageIndex":5},{"imageOffset":509344,"symbol":"CFRunLoopRunSpecific","symbolLocation":676,"imageIndex":5},{"imageOffset":197264,"symbol":"RunCurrentEventLoopInMode","symbolLocation":292,"imageIndex":6},{"imageOffset":196384,"symbol":"ReceiveNextEventCommon","symbolLocation":220,"imageIndex":6},{"imageOffset":196132,"symbol":"_BlockUntilNextEventMatchingListInModeWithFilter","symbolLocation":76,"imageIndex":6},{"imageOffset":240120,"symbol":"_DPSNextEvent","symbolLocation":660,"imageIndex":7},{"imageOffset":236092,"symbol":"-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:]","symbolLocation":716,"imageIndex":7},{"imageOffset":185740,"symbol":"-[NSApplication run]","symbolLocation":476,"imageIndex":7},{"imageOffset":18428,"symbol":"NSApplicationMain","symbolLocation":880,"imageIndex":7},{"imageOffset":689100,"imageIndex":4},{"imageOffset":23614480,"imageIndex":4},{"imageOffset":14279432,"imageIndex":4},{"imageOffset":219896,"imageIndex":2},{"imageOffset":24664,"symbol":"start","symbolLocation":2224,"imageIndex":8}]},{"id":1535254,"frames":[{"imageOffset":7720,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":10}],"threadState":{"x":[{"value":6122467328},{"value":4611},{"value":6121930752},{"value":0},{"value":409603},{"value":18446744073709551615},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0}],"flavor":"ARM_THREAD_STATE64","lr":{"value":0},"cpsr":{"value":4096},"fp":{"value":0},"sp":{"value":6122467328},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":6546578984},"far":{"value":8202642000}}},{"id":1535255,"frames":[{"imageOffset":7720,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":10}],"threadState":{"x":[{"value":6123040768},{"value":5635},{"value":6122504192},{"value":0},{"value":409604},{"value":18446744073709551615},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0}],"flavor":"ARM_THREAD_STATE64","lr":{"value":0},"cpsr":{"value":4096},"fp":{"value":0},"sp":{"value":6123040768},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":6546578984},"far":{"value":4556668928}}},{"id":1535257,"frames":[{"imageOffset":7720,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":10}],"threadState":{"x":[{"value":6123614208},{"value":20483},{"value":6123077632},{"value":0},{"value":409602},{"value":18446744073709551615},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0}],"flavor":"ARM_THREAD_STATE64","lr":{"value":0},"cpsr":{"value":4096},"fp":{"value":0},"sp":{"value":6123614208},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":6546578984},"far":{"value":7992246276}}},{"id":1535272,"name":"com.apple.NSEventThread","threadState":{"x":[{"value":268451845},{"value":21592279046},{"value":8589934592},{"value":164956808937472},{"value":0},{"value":164956808937472},{"value":2},{"value":4294967295},{"value":18446744073709550527},{"value":38407},{"value":0},{"value":1},{"value":38407},{"value":2202015},{"value":0},{"value":0},{"value":18446744073709551569},{"value":8163612680},{"value":0},{"value":4294967295},{"value":2},{"value":164956808937472},{"value":0},{"value":164956808937472},{"value":6124757096},{"value":8589934592},{"value":21592279046},{"value":21592279046},{"value":4412409862}],"flavor":"ARM_THREAD_STATE64","lr":{"value":6546411024},"cpsr":{"value":4096},"fp":{"value":6124756944},"sp":{"value":6124756864},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":6546336148},"far":{"value":4309925888}},"frames":[{"imageOffset":6548,"symbol":"mach_msg2_trap","symbolLocation":8,"imageIndex":11},{"imageOffset":81424,"symbol":"mach_msg2_internal","symbolLocation":80,"imageIndex":11},{"imageOffset":42448,"symbol":"mach_msg_overwrite","symbolLocation":476,"imageIndex":11},{"imageOffset":7448,"symbol":"mach_msg","symbolLocation":24,"imageIndex":11},{"imageOffset":518112,"symbol":"__CFRunLoopServiceMachPort","symbolLocation":160,"imageIndex":5},{"imageOffset":512192,"symbol":"__CFRunLoopRun","symbolLocation":1208,"imageIndex":5},{"imageOffset":509268,"symbol":"CFRunLoopRunSpecific","symbolLocation":600,"imageIndex":5},{"imageOffset":1462652,"symbol":"_NSEventThread","symbolLocation":144,"imageIndex":7},{"imageOffset":28724,"symbol":"_pthread_start","symbolLocation":136,"imageIndex":10},{"imageOffset":7740,"symbol":"thread_start","symbolLocation":8,"imageIndex":10}]},{"id":1535274,"frames":[{"imageOffset":7720,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":10}],"threadState":{"x":[{"value":6125334528},{"value":61975},{"value":6124797952},{"value":0},{"value":409604},{"value":18446744073709551615},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0}],"flavor":"ARM_THREAD_STATE64","lr":{"value":0},"cpsr":{"value":4096},"fp":{"value":0},"sp":{"value":6125334528},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":6546578984},"far":{"value":7992246276}}}],
  "usedImages" : [
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 4351721472,
    "size" : 49152,
    "uuid" : "3bae9099-c393-341e-a1d1-d29a814e9e91",
    "path" : "\/usr\/lib\/libobjc-trampolines.dylib",
    "name" : "libobjc-trampolines.dylib"
  },
  {
    "source" : "P",
    "arch" : "arm64",
    "base" : 4352950272,
    "CFBundleShortVersionString" : "2.4.0",
    "CFBundleIdentifier" : "org.sparkle-project.Sparkle",
    "size" : 278528,
    "uuid" : "1be8bc4c-469f-3d72-8c5a-1d2c7900a48b",
    "path" : "\/Applications\/Whisky.app\/Contents\/Frameworks\/Sparkle.framework\/Versions\/B\/Sparkle",
    "name" : "Sparkle",
    "CFBundleVersion" : "2025"
  },
  {
    "source" : "P",
    "arch" : "arm64",
    "base" : 4344971264,
    "CFBundleShortVersionString" : "pre-0.3.0",
    "CFBundleIdentifier" : "com.isaacmarovitz.Whisky",
    "size" : 1966080,
    "uuid" : "57afcf99-db2d-359f-acf8-86fcac48cc94",
    "path" : "\/Applications\/Whisky.app\/Contents\/MacOS\/Whisky",
    "name" : "Whisky",
    "CFBundleVersion" : "13"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6564417536,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.Foundation",
    "size" : 12595200,
    "uuid" : "8e405dbe-a82f-34c0-94e3-72ae1bc9b374",
    "path" : "\/System\/Library\/Frameworks\/Foundation.framework\/Versions\/C\/Foundation",
    "name" : "Foundation",
    "CFBundleVersion" : "2036"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 7259377664,
    "CFBundleShortVersionString" : "5.0.59.1.401",
    "CFBundleIdentifier" : "com.apple.SwiftUI",
    "size" : 30392320,
    "uuid" : "afb94af7-1b31-35f6-b966-d13a92da705b",
    "path" : "\/System\/Library\/Frameworks\/SwiftUI.framework\/Versions\/A\/SwiftUI",
    "name" : "SwiftUI",
    "CFBundleVersion" : "5.0.59.1.401"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6546989056,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.CoreFoundation",
    "size" : 5066752,
    "uuid" : "e091b645-7851-3e17-9b9e-8dac876e2dd7",
    "path" : "\/System\/Library\/Frameworks\/CoreFoundation.framework\/Versions\/A\/CoreFoundation",
    "name" : "CoreFoundation",
    "CFBundleVersion" : "2036"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6719168512,
    "CFBundleShortVersionString" : "2.1.1",
    "CFBundleIdentifier" : "com.apple.HIToolbox",
    "size" : 2883584,
    "uuid" : "f1550532-cf27-3c73-bef9-deb5915e2103",
    "path" : "\/System\/Library\/Frameworks\/Carbon.framework\/Versions\/A\/Frameworks\/HIToolbox.framework\/Versions\/A\/HIToolbox",
    "name" : "HIToolbox"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6604820480,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.AppKit",
    "size" : 18255872,
    "uuid" : "81b7d006-5a82-3837-af26-3b169bbded5f",
    "path" : "\/System\/Library\/Frameworks\/AppKit.framework\/Versions\/C\/AppKit",
    "name" : "AppKit",
    "CFBundleVersion" : "2450.18"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6542929920,
    "size" : 604404,
    "uuid" : "c4c87b0c-f89d-3d40-ae04-a6a5cd6f7507",
    "path" : "\/usr\/lib\/dyld",
    "name" : "dyld"
  },
  {
    "size" : 0,
    "source" : "A",
    "base" : 0,
    "uuid" : "00000000-0000-0000-0000-000000000000"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6546571264,
    "size" : 53236,
    "uuid" : "989471e7-b5df-3f95-81c5-11bc964fcd4c",
    "path" : "\/usr\/lib\/system\/libsystem_pthread.dylib",
    "name" : "libsystem_pthread.dylib"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 6546329600,
    "size" : 241656,
    "uuid" : "61252d17-2b5d-37b7-bff8-3ca76d8bc349",
    "path" : "\/usr\/lib\/system\/libsystem_kernel.dylib",
    "name" : "libsystem_kernel.dylib"
  }
],
  "sharedCache" : {
  "base" : 6542180352,
  "size" : 3919183872,
  "uuid" : "2bf1bef1-01fa-3358-b814-94979a04a36b"
},
  "vmSummary" : "ReadOnly portion of Libraries: Total=1.4G resident=0K(0%) swapped_out_or_unallocated=1.4G(100%)\nWritable regions: Total=1.2G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.2G(100%)\n\n                                VIRTUAL   REGION \nREGION TYPE                        SIZE    COUNT (non-coalesced) \n===========                     =======  ======= \nAccelerate framework               128K        1 \nActivity Tracing                   256K        1 \nAttributeGraph Data               1024K        1 \nCG image                            80K        5 \nColorSync                          576K       28 \nCoreAnimation                      624K       39 \nCoreGraphics                        48K        3 \nCoreUI image data                 1392K       10 \nFoundation                          16K        1 \nKernel Alloc Once                   32K        1 \nMALLOC                           275.5M       56 \nMALLOC guard page                  288K       15 \nMALLOC_MEDIUM (reserved)         600.0M        5         reserved VM address space (unallocated)\nMALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)\nSTACK GUARD                       56.1M        6 \nStack                             10.6M        6 \nVM_ALLOCATE                        160K       10 \n__AUTH                            1423K      254 \n__AUTH_CONST                      23.1M      441 \n__CTF                               824        1 \n__DATA                             9.9M      429 \n__DATA_CONST                      21.3M      447 \n__DATA_DIRTY                      1290K      138 \n__FONT_DATA                        2352        1 \n__LINKEDIT                       869.3M        4 \n__OBJC_RO                         70.0M        1 \n__OBJC_RW                         2137K        1 \n__TEXT                           523.4M      464 \ndyld private memory                272K        2 \nmapped file                      162.9M       31 \nshared memory                      912K       16 \n===========                     =======  ======= \nTOTAL                              2.9G     2419 \nTOTAL, minus reserved VM space     2.0G     2419 \n",
  "legacyInfo" : {
  "threadTriggered" : {
    "queue" : "com.apple.main-thread"
  }
},
  "logWritingSignature" : "7b677a33089143b486ffc47ac74befd61c8342a5",
  "trialInfo" : {
  "rollouts" : [
    {
      "rolloutId" : "6246d6a916a70b047e454124",
      "factorPackIds" : {

      },
      "deploymentId" : 240000010
    },
    {
      "rolloutId" : "63508950b3714d3622fc77f7",
      "factorPackIds" : {
        "SIRI_MEMORY_SYNC_CONFIG" : "63508beab3714d3622fc7808"
      },
      "deploymentId" : 240000004
    }
  ],
  "experiments" : [
    {
      "treatmentId" : "c28e4ee6-1b08-4f90-8e05-2809e78310a3",
      "experimentId" : "6317d2003d24842ff850182a",
      "deploymentId" : 400000013
    },
    {
      "treatmentId" : "6dd670af-0633-45e4-ae5f-122ae4df02be",
      "experimentId" : "64406ba83deb637ac8a04419",
      "deploymentId" : 900000005
    }
  ]
}
}

Model: MacBookPro17,1, BootROM 10151.0.82.0.1, proc 8:4:4 processors, 8 GB, SMC 
Graphics: Apple M1, Apple M1, Built-In
Display: Color LCD, 2560 x 1600 Retina, Main, MirrorOff, Online
Memory Module: LPDDR4, Hynix
AirPort: spairport_wireless_card_type_wifi (0x14E4, 0x4378), wl0: May  8 2023 18:09:49 version 18.20.430.0.7.8.156 FWID 01-38cbf482
AirPort: 
Bluetooth: Version (null), 0 services, 0 devices, 0 incoming serial ports
Network Service: Wi-Fi, AirPort, en0
USB Device: USB31Bus
USB Device: USB31Bus
Thunderbolt Bus: MacBook Pro, Apple Inc.
Thunderbolt Bus: MacBook Pro, Apple Inc.

What version of Whisky are you using?

pre-0.3.0

What version of macOS are you using?

Sonoma (macOS 14)

Issue Language

jawshoeadan commented 1 year ago

I have the same issue on macOS 13, using a bottle made in CrossOver Edit: I was also able to reproduce the issue with a bottle created in Whisky

jawshoeadan commented 1 year ago

It seems like there's an issue with the Data.extract method

Screenshot 2023-06-19 at 12 56 07 PM Screenshot 2023-06-19 at 12 56 48 PM
IsaacMarovitz commented 1 year ago

@jawshoeadan Could you provide details as to which program you had installed?

IsaacMarovitz commented 1 year ago

Fixed in next release

irajwani commented 1 year ago

Hi Isaac,

Great work on this! I have the exact same issue.

Mac OS 14.3 Standard Whisky, Windows 10, and GPTK setup

When I launch steam and download a game, the game works and runs much better than it did in a VM like Parallels.

But when I add some other exe files, like a random .exe file to my file system within the Bottle, the bottle crashes. I tried this with two different files (legit mod injectors).

If you want, I can share the crash log/report that keeps popping up.

gorgepawns-0c commented 1 year ago

Bottle is crashing on my setup as well after installing a program. MacOS 14, Latest Whisky with rosetta and GPTK 4 installed. Bottle was created with default settings like Windows 10.