Whisky-App / Whisky

A modern Wine wrapper for macOS built with SwiftUI
https://getwhisky.app
GNU General Public License v3.0
12.95k stars 276 forks source link

Steamwebhelper issue seems region related (reproducable) #1241

Open tacoe opened 4 days ago

tacoe commented 4 days ago

Description

After some digging (since the steam issue still persisted even with the newest Whisky and Whiskywine) I noticed that the problem doesn't occur when changing system language from NL to Ukranian. Hopefully, whatever was done to fix it, can be applied to other regions as well.

Going on log files it could be something as trivial as some process failing to parse a localized date.

Steps to reproduce

Install and launch Steam in Whisky 2.3.4 with updated dependencies, with 'region' in System Settings > General > Language & Region set to Netherlands. A dialog will appear stating Steamwebhelper is not responding.

Change region to Ukranian. Repeat launch. Now, Steam launches normally.

Expected behaviour

Expected behavior is for Steam to launch successfully regardless of region set.

Logs

Whisky Version: 2.3.4
Date: 2024-11-30T11:39:12Z
macOS Version: 14.4.1

Bottle Name: Steam
Bottle URL: /Users/taco/Library/Containers/com.isaacmarovitz.Whisky/Bottles/8521AD73-522B-443B-8455-B3F772CA02CE

WhiskyWine Version: 2.4.5
Windows Version: win10
Enhanced Sync: msync

Metal HUD: false
Metal Trace: false

Arguments: start /unix /Users/taco/Library/Containers/com.isaacmarovitz.Whisky/Bottles/8521AD73-522B-443B-8455-B3F772CA02CE/drive_c/Program Files (x86)/Steam/steam.exe

Environment:
{
    "DXVK_ASYNC" = 1;
    "GST_DEBUG" = 1;
    WINEDEBUG = "fixme-all";
    WINEDLLOVERRIDES = "dxgi,d3d9,d3d10core,d3d11=b";
    WINEESYNC = 1;
    WINEMSYNC = 1;
    WINEPREFIX = "/Users/taco/Library/Containers/com.isaacmarovitz.Whisky/Bottles/8521AD73-522B-443B-8455-B3F772CA02CE";
}

msync: bootstrapped mach port on wine-3d140ab-msync.
msync: up and running.
016c:err:wininet:HTTP_ParseDate unexpected date format L"Thu, 28 Nov 2024 22:17:00 UTC"
00c4:err:winediag:wined3d_adapter_create Using the Vulkan renderer for d3d10/11 applications.
0268:err:wininet:HTTP_ParseDate unexpected date format L"Thu, 28 Nov 2024 20:58:00 UTC"

What version of Whisky are you using?

2.3.2

What version of macOS are you using?

Sonoma (macOS 14)

Issue Language

ieocin commented 2 days ago

I followed the code path of the error and wine is using this function (https://github.com/Whisky-App/wine/blob/cefdfd79e5bc41e667400e21333983caae74c04e/dlls/wininet/http.c#L4459) to parse the date string. So it expects an RFC1123 compliant date string, not sure whats the best way of fixing this.

Also I believe this is a WhiskyWine issue, so it should go to https://github.com/Whisky-App/wine/ instead.

IsaacMarovitz commented 1 day ago

I followed the code path of the error and wine is using this function to parse the date string.

Those warnings have always been present, I highly doubt that is the problem.