WhiskyTangoFawks / Expedition

9 stars 11 forks source link

Generation Slowness and Other Bugs #136

Open jplee95 opened 7 years ago

jplee95 commented 7 years ago

While generating with the trees enabled you get large spikes of lag between chunk generation and tree generation. This also comes with a massive hit to the frame rate. I have sourced where this issue occurs, and propose this fix: In your BlockMap class under the setBlocks function, changing the flag for notifyBlockUpdate to 2 instead of 3 for preventing large quantities of block updates when generating.

When using the custom ore generation, there is an every once in a while chance that the world will not start generating the ores, I have actually no idea why or where this happens.

Also for help fixing the no light areas when generating the trees, using setChunkModified from the chunk could help prevent it, though when using notifyBlockUpdate I do not know.

jplee95 commented 7 years ago

For the second item listed I have found the issue of why and has nothing to do with your mod. That one can be ignored.