WhiskyTangoFawks / Expedition

9 stars 10 forks source link

maybe fix for BlockDrop Issue mentioned on Curseforge #139

Open NitroxydeX opened 7 years ago

NitroxydeX commented 7 years ago

Curseforge Comment Link: https://minecraft.curseforge.com/projects/wtfs-expedition-gameplay?comment=13

I've worked with the here provided source and checked whenever something out of your gravity method is called or not. As it seems 'fallchance' is always 1 here: https://github.com/WhiskyTangoFawks/Expedition/blob/master/1-9Forge/src/main/java/wtf/gameplay/GravityMethods.java#L41

so instead of '<' it should be '>' to prevent infinite dropping. If you change this the loop is called too which isn't when it's '<'.

I'm really unsure what you really checking for.

This seems to be working always now. 2017-04-24_19 38 57

While this checks now against the function (and the provided values in the configs) and not always happens, but it still seems to be not really e.g 50%. 2017-04-24_19 39 00

Now there is a question: should both situation get checked? then there is something really different wrong.

WhiskyTangoFawks commented 7 years ago

How falling blocks work is a little more complicated than just a simple check. But yes, there was an issue where it wasn't getting the initial value, and instead just using 1. Probably was testing something and just forgot to set it back.

Next release will have the fix.