search

WhiskyTangoFawks / Expedition

9 stars 10 forks source link

Quarry integration #80

Open kragnoth opened 7 years ago

kragnoth commented 7 years ago

Would it be possible for quarry integration to account for custom dense ore types? I tested a modpack I'm building with rftools 5.8.1, and the builder (and I'm assuming other quarries that handle nbt similarly) dug up ores that I had assigned to andesite textures (redstone on andesite as an example) and they were dug up with a nbt value of 1. This resulted in ores with no textures in the chest and inventory, and when placed took on the stone background texture.

All overlays were tested mining by hand to work properly.

edit: this is with silk touch only it seems. Maybe a way to override silk touch so that it only returns a normal block return, and not the original block.

WhiskyTangoFawks commented 7 years ago

Quarry integration needs to happen on the side of whatever quarry mod your using. Your post is a little confising, but if I read it correctly, you have some sort of mod that adds a silk touch quary device, and that isn't working?

As I have no clue how that works, I can't really do anything about that, particularly as the method that mod should probably be calling (getBlockDrops()) doesn't have a silk touch modifier- which means they've probably had to hack in, which is why my blocks are being odd. If you want to open up an issue there and reference this one, maybe the other author can explain it.

kragnoth commented 7 years ago

Sorry, I wrote this before going to bed. For now I just removed the silk touch quarry from rftools from being craftable. For better reference: Builder quarry - set to silk touch Blocks being quarried: Dense Stone Ardite Iron Ore (does the same for any ore where the original background block had a meta tag, i.e. stone@1)

Block returned: untextured Dense Stone Iron Ore (with a meta tag of 1). I'll post this same thing to rftools and see if it is something mcjty can fix.