WhiskyTangoFawks / Expedition

9 stars 10 forks source link

[Crash] Adding mod ores to master list #96

Open Dragnier opened 7 years ago

Dragnier commented 7 years ago

Mod: libvulpes (required by Advanced Rocketry)

Adding ores from this mod to the master list make your mod crash. This is probably due to the naming of the ores in libvulpes as they use the number 0 in the block name portion.

How they would look in your config file:

libvulpes:ore0@0 #cave&cluster libvulpes:ore0@10 #cave&single

Here is the crash report:

crash-2017-01-31_23.47.39-client.txt

WhiskyTangoFawks commented 7 years ago

It is due to the naming, but nothing to do with having a number in them- it's because you've added two blocks with the same registry name. The author has named different ores the same thing in the registry, and just relied on metadata to differentiate them.

Add one block. Then change the Block Registry Name option in it's config- this is the name of the block that will be generated, and it has to be unique for every different ore added.

Dragnier commented 7 years ago

That isn't a problem with other mods that do this. I had several configured mod ores that worked just fine this way. The following worked just fine:

funores:MetalOre@0 funores:MetalOre@1 funores:MetalOre@2 funores:MetalOre@3 funores:MetalOre@4 funores:MetalOre@6 funores:MetalOre@7 funores:MetalOre@8

However, I've encountered another problem with the pack I was making regarding another mod and have scrapped the project for the time being. I just figured you'd want to know that ores having the same name and multiple meta is a relatively common practice and not what was causing this issue.

Dragnier commented 7 years ago

So, apparently the other issue I mentioned might be on your end as well... Ore specified in your config wasn't generating in other dimensions from the Advanced Rocketry mod and I thought it just wasn't getting called or something.

However looking at the issue I made over there, the author said that even though you have a specification for dimension in your configs that it probably isn't working outside of the overworld and nether. If that is the case, then your config needs to be more specific about what dimensions it can and cannot world/ore gen for and you may consider adding support for other dimensions... especially with things like AR and RFTools Dimensions.

WhiskyTangoFawks commented 7 years ago

Still not sure about that first issue, but the second one is easy to fix, and I'll have a new version out today or tomorrow hopefully