torrent.State of "forcedMetaDL" should be treated the same as "MetaDL"

codersaur commented 1 week ago

Is there an existing issue for this?

[X] I have searched the existing open and closed issues

Current Behavior

In src/NzbDrone.Core/Download/Clients/QBittorrent/QBittorrent.cs items with torrent.State of "forcedMetaDL" are mapped to an item.Status of DownloadItemStatus.Downloading. This does not match the logic used by other similar arr apps.

Expected Behavior

The DownloadItemStatus of items with torrent.State of "forcedMetaDL" in qBittorrent should be determined in the same way as those with torrent.State of "MetaDL". This will then match the logic used by other arr apps. (e.g. https://github.com/Sonarr/Sonarr/blob/86446a768627b98909389eac230720fcd00cb127/src/NzbDrone.Core/Download/Clients/QBittorrent/QBittorrent.cs#L286-L287).

The fix is to move the following line up to the previous section: case "forcedMetaDL": // torrent metadata is being forcibly downloaded

Steps To Reproduce

Torrent in "forcedMetaDL" state in qBittorrent.

Environment

- OS: Ubuntu 24.04
- Whisparr: 2.0.0.548
- Docker Install: Yes
- Using Reverse Proxy: Yes
- Browser: N/A
- Database: Sqlite 3.44.2

What branch are you running?

Main

Trace Logs?

N/A

Anything else?

No response

enymawse commented 1 week ago

I think V2 is EOL. This issue is resolved in V3 though.

codersaur commented 1 week ago

Is there a documented upgrade path fom v2 to v3?

enymawse commented 1 week ago

If there is, I'm not aware of one. I would jump in the discord server and ask there if you don't get a response here.

plz12345 commented 1 week ago

There is no upgrade path. V2 and V3 are based on different *arr software.

codersaur commented 1 week ago

Well if that's the case, can this issue not be fixed in v2?

plz12345 commented 1 week ago

Unlikely to happen. Can it? Sure. But none of the deva are spending time on v2.

Whisparr / Whisparr