While looking through the code in make_figures.py (note: not scripts/make_figure.py) I've noted my findings.
1) view_corr_mat is redundant, because it is already implemented in scripts/visualisation_commands.py
Basically, it is almost identical function to one in scripts/visualisation_commands.py. The one in visualisation_commands.py is better because PR #108 updated the view_corr_mat in visualisation_commands.py, now the function accepts corr_mat as a dataframe object, numpy_array, and as a path to file containing corr_mat
2) get_anatomical_layouts has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run
3) plot_anatomical_network has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run
Note: the last the 2 functions are implemented in scripts/make_figures.py, the 1st function in scripts/visualisation_commands.py.
Was the purpose of creating this file to refactor the scripts/make_figures.py file? Because scripts/make_figures.py file is messy and 4000 lines long, so it definitely needs to be refactored.
While looking through the code in make_figures.py (note: not scripts/make_figure.py) I've noted my findings.
1)
view_corr_mat
is redundant, because it is already implemented in scripts/visualisation_commands.pyscripts/visualisation_commands.py
. The one in visualisation_commands.py is better because PR #108 updated theview_corr_mat
in visualisation_commands.py, now the function accepts corr_mat as a dataframe object, numpy_array, and as a path to file containing corr_mat2)
get_anatomical_layouts
has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run3)
plot_anatomical_network
has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not runNote: the last the 2 functions are implemented in scripts/make_figures.py, the 1st function in scripts/visualisation_commands.py.
Was the purpose of creating this file to refactor the scripts/make_figures.py file? Because scripts/make_figures.py file is messy and 4000 lines long, so it definitely needs to be refactored.