WhitakerLab / scona

Code to analyse structural covariance brain networks using python.
https://whitakerlab.github.io/scona/
MIT License
68 stars 33 forks source link

Review of functions in make_figures.py #113

Open wingedRuslan opened 5 years ago

wingedRuslan commented 5 years ago

While looking through the code in make_figures.py (note: not scripts/make_figure.py) I've noted my findings.

1) view_corr_mat is redundant, because it is already implemented in scripts/visualisation_commands.py

2) get_anatomical_layouts has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run

3) plot_anatomical_network has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run

Note: the last the 2 functions are implemented in scripts/make_figures.py, the 1st function in scripts/visualisation_commands.py.

Was the purpose of creating this file to refactor the scripts/make_figures.py file? Because scripts/make_figures.py file is messy and 4000 lines long, so it definitely needs to be refactored.

Islast commented 5 years ago

This was indeed my first pass at refactoring the code inside scripts/make_figures . Feel free to abandon it and start over if it's not helpful to you