import inside functions

[wingedRuslan]

Hi!

There are a bunch of functions, where import statements are inside the functions' body. Is this made intentionally? Should I refactor and include import only at the top of a module??

Some references: 1) PEP8

Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. 2) StackOverFlow Answer

Module importing is quite fast, but not instant. This means that:

• Putting the imports at the top of the module is fine, because it's a trivial cost that's only paid once.
• Putting the imports within a function will cause calls to that function to take longer.

[Islast]

Yes you should always refactor the imports to be at the top of the module

[Islast]

self assigning so that I remember to add this to the development guide

[wingedRuslan]

@Islast What are you planning to add to the guide?

[Islast]

A note that in general imports should go at the top of the file

[KirstieJane]

(This is almost certainly me having no idea what I was doing when I wrote this code! Thank you for doing a much cleaner job @wingedRuslan & @Islast 💖)

[Islast]

Closing since #120 adds this style reccomendation to the documentation