KirstieJane
commented
6 years ago 
How fun that the browser icon shows that the tests are passing!!
Closed Islast closed 6 years ago
KirstieJane
commented
6 years ago
How fun that the browser icon shows that the tests are passing!!
schae234
commented
6 years ago I can't count the number of times I've fixed bugs to get that little badge 😀
Even cooler that they change the favicon!
On Wed, Jan 31, 2018, 9:43 AM Kirstie Whitaker notifications@github.com wrote:
@KirstieJane commented on this pull request.
This all looks great - and excellent that the tests are passing.
I agree that it would be nice to add a note about this to the README file, can we do this as part of this commit?
I'm not clear on whether the tests are now only testing networkx 2.0 or both 1.9 and 2.0? Are we capable of running for both?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WhitakerLab/BrainNetworksInPython/pull/55#pullrequestreview-92970269, or mute the thread https://github.com/notifications/unsubscribe-auth/ACcpv1dtwCysjXjq__GGBkLPHz1tr2Rfks5tQIohgaJpZM4RQrz- .
--
Rob Schaefer, PhD
USDA-NIFA Postdoctoral Fellow Equine Genetics and Genomics Lab University of Minnesota @CSciBio https://twitter.com/CSciBio
Islast
commented
6 years ago Travis now tests networkx versions 1.9 and 2.0 :sparkles:
[x] I'm ready to merge
What's the context for this pull request? issue #54
What's new?
What should a reviewer feedback on? The changes listed above
Does anything need to be updated after merge? (e.g the wiki or the WhitakerLab website)
Yes, I think we should definitely add "now supports networkx 2.0, networkx1.9 is still working but deprecated" to the wiki etc