WhitakerLab / scona

Code to analyse structural covariance brain networks using python.
https://whitakerlab.github.io/scona/
MIT License
68 stars 33 forks source link

Check out new testing branch #8

Closed Islast closed 7 years ago

Islast commented 7 years ago

This is for @KirstieJane to remind her to look at the new testing branch. There's a lot of junk in there right now, firsttest.py and write_fixtures.py are the ones to check out!

KirstieJane commented 7 years ago

Awesome - thank you @Islast!

I think the biggest challenge that I have at the moment is reading through the firsttest.py & write_fixtures.py files. Would you mind adding some comments to the functions to make it a little clearer.

I think, for example, that the actual running of the code in firsttest.py happens on line 8, is that right? and then filecmp compares files to check they're the same?

In the longer run, a little document explaining our (the project's) philosophy on testing would be really great. Something like 2-3 paragraphs and some links to useful resources and the specific tools you're using would be really helpful :smile:

Thank you again fro doing all this exploration!! I'm very excited about these tests!

Islast commented 7 years ago

Thanks! I had a feeling it was a bit obtuse. I'll try to make it clearer :sparkles:. And Yes a document explaining where we're at with testing is an excellent idea. Would the wiki be an appropriate place for that?