search

WhitakerLab / scona

Code to analyse structural covariance brain networks using python.
https://whitakerlab.github.io/scona/
MIT License
68 stars 33 forks source link

Broken links & broken badges in CONTRIBUTING guidelines #9

Closed KirstieJane closed 7 years ago

KirstieJane commented 7 years ago

The CONTRIBUTING guidelines for this project use shield.io badges to make the labels look pretty. (Scroll down on http://shields.io to the My Badge section to see how they're made).

Some are broken though!

There are two errors as it stands in the CONTRIBUTING file:

  1. The badge has a - in the name which is not working any more. The name of the link to the badge needs to be replaced with -- where - is supposed to be rendered in the text of the badge.

    For example at the moment https://img.shields.io/badge/-no-code-207de5.svg does not render but https://img.shields.io/badge/-no--code-207de5.svg does show up as .

  2. Some of the links are mis-typed.

    For example [link_bugs] doesn't actually exist, but there is a [link_bug] in the list at the end of the CONTRIBUTING file. Same with [link_requests] which should be [link_request].

It would be great to have these fixed! Ping me if you have any questions @jlee124! 🌮 ✨

KirstieJane commented 7 years ago

Issue can be closed?

faheel commented 7 years ago

Yep, my bad! I forgot to refer it in my PR. I'll close it now as these errors have been fixed.

KirstieJane commented 7 years ago

No problem @faheel! Thank you so much for contributing :sparkles: