search

WhitakerLab / whitakerlab.github.io

Updates from Kirstie's research group at the Turing Institute.
https://whitaker-lab.netlify.app
MIT License
6 stars 17 forks source link

Travis error - incorrect html tag somewhere #18

Closed KirstieJane closed 7 years ago

KirstieJane commented 7 years ago

In our travis log we have an Unexpected end tag : a (line 137).

I think this is to do with this section (lines 33 & 35) in the _layouts/post.html file.

I wonder if someone with a little better understanding of html could tell me the right edit to make. I think I can just remove the </a> tag...but I'd love a sanity check on this :smile:

KirstieJane commented 7 years ago

Hi @auremoser, @bmpvieira, @teonbrooks & @acabunoc. Do any of you have time to quickly skim this?? Thank you!!

auremoser commented 7 years ago

Hot take, but this feels weird for me:

<img src="{{ author.avatar }}" class="bio-photo" alt="{{ author.name }} bio photo"></a>

To your point, because it closes an <a href> that I can't immediately see the source/start of, so either add that href to preceed the <img> or remove the </a>

teonbrooks commented 7 years ago

echo @auremoser, I don't think you need the trailing

KirstieJane commented 7 years ago

Mega🌟! Thank you @auremoser & @teonbrooks. I'll create an issue in the parent repo & double check that there isn't supposed to be an <a href>. Might as well fix the issue there rather than just here 😀 .

KirstieJane commented 7 years ago

Fixed in the master branch now and merged to this fork. Yaaaay!