search

WhitakerLab / whitakerlab.github.io

Updates from Kirstie's research group at the Turing Institute.
https://whitaker-lab.netlify.app
MIT License
6 stars 17 forks source link

Create 2019-08-13-Ang-Li-Three-People-in-Turing.md #67

Open sparkler0323 opened 5 years ago

KirstieJane commented 5 years ago

@sparkler0323 - why are some of these reviews marked resolved when they aren't updated yet?

Please also update from master because I've fixed the Travis continuous integration and so it will now actually tell you something useful (rather than break all the time)!

Ping me in the slack channel when you've addressed @GeorgiaHCA's points and I'll have a read through ✨

sparkler0323 commented 5 years ago

@KirstieJane So sorry, as I couldn't find out how to make an edit inside this pull request. Should I close this pull request and re-edit it in my Github?

KirstieJane commented 5 years ago

Hi @sparkler0323 - if you make changes in your repository's master branch the pull request will automatically update ✨ Ping @GeorgiaHCA or @minnieho1115 in the slack channel if you're having any difficulties 😄

KirstieJane commented 5 years ago

@sparkler0323 - I can only see a couple of sentences on separate lines - can you please go through the blog post and put them all on separate lines for me to review?

KirstieJane commented 5 years ago

Hi @sparkler0323! I've fixed the broken links in the master branch - please can you update your branch so that CI passes?

KirstieJane commented 5 years ago

Pinging again - I'd like to get this blog post merged - its been open for 2 months.

Let me know if you have any questions about updating the branch @sparkler0323.

sparkler0323 commented 5 years ago

Hi @KirstieJane, it will be great if you can help me the error. I have updated your master to my Github repository and I'm not sure why the merge fails. Thanks for your time!

KirstieJane commented 5 years ago

Hi @sparkler0323! If you click on the "Details" link next to the Travis CI you can see what the error is - in this case its that it's a broken link in a different blog post - I can fix that 😄

Thank you! I'll review over the weekend ✨