White-Oak / qml-rust

QML (Qt Quick) bindings for Rust language
MIT License
205 stars 18 forks source link

Use QGuiApplication, not QApplication, in qmlengine.rs #36

Closed Thra11 closed 7 years ago

Thra11 commented 7 years ago

QtQuick requires a QGuiApplication. QApplication derives from QGuiApplication, so it can do the job, but it creates an unnecessary dependency on QtWidgets, which is undesirable for a QtQuick-only application.

Thra11 commented 7 years ago

Note that to actually break the dependency on QtWidgets, DOtherSide also requires a small modification (DOtherSide PR).

Thra11 commented 7 years ago

@White-Oak Was it just the DOtherSide changes blocking this, or did you have other concerns that need addressing?

White-Oak commented 7 years ago

@Thra11 can you update the dotherside submodule?