search

White-Tiger / WinMTR

WinMTR Redux, extended fork of Appnor's WinMTR with IPv6 support and other enhancements
GNU General Public License v2.0
437 stars 63 forks source link

Checking your unfinished work from April '14 into GitHub #3

Open unforgettableid opened 7 years ago

unforgettableid commented 7 years ago

Hi!

In your first comment to issue #1, you included a screenshot of your unpublished version from April '14. You added: "I sadly didn't have time to finalize all things and publish it yet."

Fair enough. But why not at least check your unfinished work into GitHub? :)

P.S. Thank you for your work on WinMTR!

White-Tiger commented 7 years ago

well... I get your point and would totally agree if I've given up on it already, but I didn't yet and would like to finish that work! (and maybe use a newer GeoIP API if the Windows "port" is done)

Yet there's a reason why I don't like to push such unfinished stuff.. (not even as a branch I'll just delete once it's done) It's currently a rather dirty implementation... And not only from a users point of view with lacking UI and glitches but also from the source side with stuff commented out etc.... Which I might simply "rewrite" if I find a different approach to be better suited. Currently, It's using Maxmind's GeoIP and asking for activation on launch (as it wouldn't be allowed for commercial use without prior permissions) The context menu is also mostly WiP and incomplete... (and currently only opens webpages or other external tools) and requires a proper local implementation for whois.

However, if someone is interested to work on it further, I'm willing to release the code in private if someone is willing to work on it (or do it better) and won't release it before it's in a "done"/"usable" and cleaned up state...

And one more thing.. I'm not even sure about the source license, or rather don't remember if Maxmind was compatible without "outsourcing" it...

White-Tiger commented 7 years ago

Well... I've took a look the other day, and found out that there were quite a lot changes which even fixed some build errors (like the missing manifest file) So right now, I'm reviewing my changes and split them into smaller commits (my old "coding-style" happened to do a lot of partially "unrelated" changes within a single commit)

Will either commit my GeoIP additions once done, or commit only some earlier changes.

Which "feature" are you particularly interested in?

unforgettableid commented 7 years ago

Which "feature" are you particularly interested in?

Dunno. The right-click menu might be nice.

The context menu is also mostly WiP and incomplete

You can check messy and incomplete code into a branch. :)

... and requires a proper local implementation for Whois.

I don't need Whois. But, by the way, Whois is available online. For example, you can try this link: http://whois.domaintools.com/example.com

White-Tiger commented 7 years ago

It's actually the same whois site that I've been using... The second whois was http://whois.net/ip-address-lookup/ and for IP2Location it's been those two: http://dnsquery.org/ip2location/ http://ip2location.com/

FranklinYu commented 6 years ago

Any news? Need help?