[reviewing] patch white whale for 2 newly disclosed bugs

White-Whale-Defi-Platform / migaloo-chain

Migaloo is a cosmwasm-powered, permissionless blockchain for building decentralized applications.

https://migaloo.zone

MIT License

51 stars 28 forks source link

[reviewing] patch white whale for 2 newly disclosed bugs #329

Closed faddat closed 6 months ago

faddat commented 6 months ago

Description and Motivation

Related Issues

Checklist:

[ ] I have read Migaloo's contribution guidelines.
[ ] My pull request has a sound title and description (not something vague like Update index.md)
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation.
[ ] The code is formatted properly golangci-lint run ./... --fix.

kienn6034 commented 6 months ago

I updated logic for the patch to work, and added the encoding scheme for generating packet in the ica test.

kienn6034 commented 6 months ago

@faddat please review this?

faddat commented 6 months ago

yep

On Mon, Feb 26, 2024 at 4:46 PM Kien @.***> wrote:

@faddat https://github.com/faddat please review this?

— Reply to this email directly, view it on GitHub https://github.com/White-Whale-Defi-Platform/migaloo-chain/pull/329#issuecomment-1964317980, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWPVCLD56ICTGSAIMYXU3DYVSN3PAVCNFSM6AAAAABDX5SKUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGMYTOOJYGA . You are receiving this because you were mentioned.Message ID: @.***>

faddat commented 6 months ago

@kienn6034 I approve, but need two reviewers who aren't me to approve it, since I started the PR.

🖖