Bug: binary search ends up infinite recursion

White-Whale-Defi-Platform / white-whale-bots

A single-chain and multi-dex arbitrage bot the utilizing White Whale flash loans and Skip Protocol.

https://whitewhale.money

MIT License

81 stars 32 forks source link

Bug: binary search ends up infinite recursion #108

Closed SirTLB closed 1 year ago

SirTLB commented 1 year ago

The recently updated binary search function uses recursion to solve optimal tradesize problem for orderbook paths. It sometimes gets stuck in an infinite recursion (resulting in max call stack error) because non of the default return conditions are met.

SirTLB commented 1 year ago

this is fixed with commit c3e2fe337ec3049933770c2b6d80b0678cd51f0f