kerber0x commented 3 months ago

Description and Motivation

This PR addresses #306, adding the asset_decimals vector to the create_pair msg so there's no need to fetch these from anywhere.

Related Issues

[x] I have read Migaloo's contribution guidelines.
[x] My pull request has a sound title and description (not something vague like Update index.md)
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation.
[x] The code is formatted properly cargo fmt --all --.
[x] Clippy doesn't report any issues cargo clippy -- -D warnings.
[x] I have regenerated the schemas if needed cargo schema.

kerber0x commented 3 months ago

Looks good overall, made some minor comments / recommendations. Tests are failing on CI

Thanks, yes the tests will keep failing, we will fix them afterwards

github-actions[bot] commented 3 months ago

Schema generation had missing jobs:

contracts/liquidity_hub/pool-manager/schema/pool-manager.json
contracts/liquidity_hub/pool-manager/schema/raw/query.json

Please run just schemas locally and upload the generated schemas.