refactor: add SimulationResponse and ReverseSimulationResponse to the…

White-Whale-Defi-Platform / white-whale-core

Core contracts for White Whale, The Interchain Liquidity Protocol for the Cosmos.

https://whitewhale.money

MIT License

36 stars 23 forks source link

refactor: add SimulationResponse and ReverseSimulationResponse to the… #330

Closed kerber0x closed 3 months ago

kerber0x commented 3 months ago

… pool_manager package

Description and Motivation

Minor refactor adding (duplicating) the simulation quiery responses to the pool_manager package, as it was using the ones from the pool factory.

Related Issues

Checklist:

[x] I have read Migaloo's contribution guidelines.
[x] My pull request has a sound title and description (not something vague like Update index.md)
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation.
[x] The code is formatted properly cargo fmt --all --.
[x] Clippy doesn't report any issues cargo clippy -- -D warnings.
[x] I have regenerated the schemas if needed cargo schema.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.40%. Comparing base (64ec60f) to head (0d3ac38). Report is 8 commits behind head on release/v2_contracts.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/v2_contracts #330 +/- ## ======================================================== - Coverage 89.42% 89.40% -0.02% ======================================================== Files 260 260 Lines 26656 26642 -14 ======================================================== - Hits 23836 23820 -16 - Misses 2820 2822 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kerber0x commented 3 months ago

LGTM.

Are we planning on removing the pool_network mod from white-whale-std at some point? i.e., what do we want to do about asset::PairType and factory:NativeTokenDecimalsResponse?

Since V1 and V2 will live in parallel, maybe we will need to restructure the project a bit, let's see. However, whatever it's not being used we should remove.