White-Whale-Defi-Platform / white-whale-core

Core contracts for White Whale, The Interchain Liquidity Protocol for the Cosmos.
https://whitewhale.money
MIT License
36 stars 23 forks source link

Send protocol fees from pool manager via FillRewards rather than BankMsg #334

Closed kaimen-sano closed 3 months ago

kaimen-sano commented 3 months ago

Description and Motivation

We currently use BankMsg::Send when a swap has occurred to send the protocol fees to the whale-lair. This is not desired, as it does not allow the whale-lair contract to hook into receiving the assets.

Related Issues

Closes #312.

Adding a integration test for this behaviour this is hard due to https://github.com/CosmWasm/cw-plus/issues/763. Unfortunately the cosmwasm team is not interested in addressing this issue.


Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.50%. Comparing base (a8ebb95) to head (e180cc6). Report is 1 commits behind head on release/v2_contracts.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v2_contracts #334 +/- ## ===================================================== Coverage 89.49% 89.50% ===================================================== Files 261 261 Lines 26646 26650 +4 ===================================================== + Hits 23848 23852 +4 Misses 2798 2798 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.