Closed kerber0x closed 5 months ago
Attention: Patch coverage is 96.77996%
with 18 lines
in your changes are missing coverage. Please review.
Project coverage is 90.08%. Comparing base (
deebeee
) to head (5f5b6a8
). Report is 4 commits behind head on release/v2_contracts.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I like this implementation but on second view it looks like Osmosis does do a swap before provision rather than only providing to one side. Additionally looks like Wynd did that too. The behaviour of single provision and only providing to one side is similar to Uniswap. Do we want maybe to add an option to do the swap? https://medium.com/osmosis-community-updates/single-asset-lp-67fb48abce53
I like this implementation but on second view it looks like Osmosis does do a swap before provision rather than only providing to one side. Additionally looks like Wynd did that too. The behaviour of single provision and only providing to one side is similar to Uniswap. Do we want maybe to add an option to do the swap? https://medium.com/osmosis-community-updates/single-asset-lp-67fb48abce53
Good point. Let's explore doing it this way.
Schema generation had missing jobs:
contracts/liquidity_hub/pool-manager/schema/pool-manager.json
contracts/liquidity_hub/pool-manager/schema/raw/execute.json
Please run just schemas
locally and upload the generated schemas.
Schema generation had missing jobs:
contracts/liquidity_hub/pool-manager/schema/pool-manager.json
contracts/liquidity_hub/pool-manager/schema/raw/execute.json
Please run just schemas
locally and upload the generated schemas.
Description and Motivation
Enables single-side liquidity provision. Closes #310
Related Issues
Checklist:
Update index.md
)cargo fmt --all --
.cargo clippy -- -D warnings
.cargo schema
.